mediatomb/gerbera: Add release note information for 21.03#100348
Closed
ardumont wants to merge 1 commit intoNixOS:masterfrom
Closed
mediatomb/gerbera: Add release note information for 21.03#100348ardumont wants to merge 1 commit intoNixOS:masterfrom
ardumont wants to merge 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
6.topic: nixos
Contributor
Author
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
Contributor
Author
|
Updated and fixed the conflict |
Member
|
@ardumont please resolve the merge conflict. |
SuperSandro2000
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
Note that it made into 2 entries, one about new options in the first section. Another in the breaking compatibility section due to the openFirewall option which changes the behavior.
Contributor
Author
Btw, I've rebased and fixed the conflict again (I did also last time you asked...). (It was also initially from another PR and it got split... The actual code describing Thanks for your time and consideration. Cheers, |
Member
|
This obviously still needs to go into 21.05, because the changes are already merged but the release note is not. Somehow the manual is failing to build, can you check and resolve this @ardumont? /cc @jonringer |
Member
|
@ardumont Did you see that unfortunately the NixOS tests for mediatomb are failing because of gerbera, while mediatomb still succeeds? First, the With gerbera understandibly being the new default, this is pretty bad. |
10 tasks
schmittlauch
suggested changes
May 28, 2021
Member
schmittlauch
left a comment
schmittlauch
left a comment
There was a problem hiding this comment.
After cleaning up all the proposed typos and misconceptions, I can confirm that the manual/ release notes finally build successfully.
| All services should use <xref linkend="opt-systemd.services._name_.startLimitIntervalSec" /> or <literal>StartLimitIntervalSec</literal> in <xref linkend="opt-systemd.services._name_.unitConfig" /> instead. | ||
| </para> | ||
| </listitem> | ||
| <listItem> |
Member
There was a problem hiding this comment.
Suggested change
| <listItem> | |
| <listitem> |
| { path = "/var/lib/mediatomb/audio"; recursive = true; hidden-files = false; } | ||
| ]; | ||
| </programlisting> | ||
| </listItem> |
Member
There was a problem hiding this comment.
Suggested change
| </listItem> | |
| </listitem> |
| </listitem> | ||
| <listItem> | ||
| <para> | ||
| The <link linked="opt-services.mediatomb">mediatomb service</link> |
Member
There was a problem hiding this comment.
Suggested change
| The <link linked="opt-services.mediatomb">mediatomb service</link> | |
| The <literal>mediatomb</literal> service |
| </listitem> | ||
| <listitem> | ||
| <para> | ||
| The <link linked="opt-services.mediatomb">mediatomb service</link> is |
Member
There was a problem hiding this comment.
Suggested change
| The <link linked="opt-services.mediatomb">mediatomb service</link> is | |
| The <literal>mediatomb</literal> service is |
Member
There was a problem hiding this comment.
opt-services.mediatomb is no reference target, only its sub-options are.
| <programlisting> | ||
| services.mediatomb.package = pkgs.mediatomb; | ||
| </programlisting> | ||
| One new option <literal>openFirewall<literal> has been introduced which |
Member
There was a problem hiding this comment.
Suggested change
| One new option <literal>openFirewall<literal> has been introduced which | |
| One new option <literal>openFirewall</literal> has been introduced which |
| { path = "/var/lib/mediatomb/pictures"; recursive = false; hidden-files = false; } | ||
| { path = "/var/lib/mediatomb/audio"; recursive = true; hidden-files = false; } | ||
| ]; | ||
| </programlisting> |
Member
There was a problem hiding this comment.
Suggested change
| </programlisting> | |
| </programlisting> | |
| </para> |
This was referenced May 28, 2021
Member
|
superseded by #124768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the documentation [1] does not complain about anything
[1] https://nixos.org/manual/nixpkgs/stable/#chap-contributing
Related to #93450#issuecomment-706962271