[21.05] mediatomb: use ffmpeg instead of ffmpeg_3

[dotlambda]

Motivation for this change

backport #123487

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Added a release notes entry if the change is major or breaking
• Fits CONTRIBUTING.md.

[schmittlauch]

LGTM

what was tested:

• mediatomb builds successfully
• mediatomb NixOS test continues to fail, but this is due to gerbera
• mediatomb NixOS test succeeds when removing all gerbera-specific tests

what was not tested:

• actual real-world usage of mediatomb

Having a mediatomb that builds and passes tests in 21.05 is preferrable over a situation where mediatomb is insecure and the alternative gerbera might be broken as it does not pass tests.

[r-rmcgibbo]

Result of nixpkgs-review pr 124757 at 989c034 run on x86_64-linux 1

1 package built successfully:

• mediatomb

3 suggestions:

• warning: build-tools-in-build-inputs

  pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/servers/mediatomb/default.nix:15:3:

     |
  15 |   buildInputs = [ sqlite expat spidermonkey_68 taglib libexif curl ffmpeg file mp4v2 flac
     |   ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/servers/mediatomb/default.nix:22:5:

     |
  22 |     license = licenses.gpl2;
     |     ^
  

• warning: build-tools-in-build-inputs

  autoreconfHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/servers/mediatomb/default.nix:15:3:

     |
  15 |   buildInputs = [ sqlite expat spidermonkey_68 taglib libexif curl ffmpeg file mp4v2 flac
     |   ^
  

[schmittlauch]

Robot is right with its suggestions, but as the goal should be to drop this package in the next release anyways I'm okay to move forward with this.