Skip to content

llvmPackages_12: Improve and extend the meta attributes#119550

Merged
primeos merged 1 commit intoNixOS:masterfrom
primeos:llvm-meta
Apr 15, 2021
Merged

llvmPackages_12: Improve and extend the meta attributes#119550
primeos merged 1 commit intoNixOS:masterfrom
primeos:llvm-meta

Conversation

@primeos
Copy link
Member

@primeos primeos commented Apr 15, 2021

Motivation for this change

Not the cleanest solution but at least it's an improvement. This is especially important for the missing licenses and maintainers (see #116646 (comment) and #119541 (comment)).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos requested a review from matthewbauer as a code owner April 15, 2021 16:45
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 15, 2021
@ofborg ofborg bot requested review from 7c6f434c, dtzWill and lovek323 April 15, 2021 16:54
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 15, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119550 at 28887e7 run on aarch64-linux 1

2 packages skipped due to time constraints:
  • llvmPackages_12.clang-manpages
  • llvmPackages_12.compiler-rt
1 package built successfully:
  • llvmPackages_12.libunwind
1 suggestion:
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/compilers/llvm/12/compiler-rt/default.nix:52:5:

       |
    52 |     ./compiler-rt-codesign.patch # Revert compiler-rt commit that makes codesign mandatory
       |     ^
    

@primeos primeos merged commit 44dac5f into NixOS:master Apr 15, 2021
@primeos primeos mentioned this pull request Apr 15, 2021
10 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments