Release Notes on mediatomb changes (to master)#124768
Merged
jonringer merged 1 commit intoNixOS:masterfrom May 28, 2021
Merged
Conversation
github-actions
bot
added
6.topic: nixos
Member
Author
|
/cc @SuperSandro2000 as a reviewer of the original PR |
9 tasks
Member
Author
|
backport: #124770 |
dotlambda
changed the title
mediatomb changes (to master)mediatomb changes (to master)
Member
|
Please squash the commits. Feel free to add |
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
|
TIL: fixup rebasing retains the original author. |
Member
|
It should usually look like |
Member
Author
|
@dotlambda thanks for the hint, as my contribution is only fixing typos I'm okay with merging as-is. |
Member
|
It's just hurting my eyes :D |
Member
Author
|
if it's really necessary, I'll do the force-push dance again 🙄 Who needs structured metadata, if you can just expect people to use a certain plain-text formatting :D |
Note that it made into 2 entries, one about new options in the first section. Another in the breaking compatibility section due to the openFirewall option which changes the behavior. Co-authored-by: schmittlauch <t.schmittlauch+nixos@orlives.de>
Member
Author
|
🎉 |
Member
Author
|
@jonringer @dotlambda Please do not forget about the backport #124770, these release notes obviously need to go to release-21.05 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The changes to the
mediatombmodule are already in master and release-21.05, but the corresponding release notes are not.Supersedes and closes #100348 by fixing the manual build.
Backport to release-21.05 follows.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)