Document string context by Ericson2314 · Pull Request #8595 · NixOS/nix

Ericson2314 · 2023-06-27T16:18:22Z

Motivation

Now what we have enough primops, we can document how string contexts work.

Context

Progress towards #7910.

~~Depends on #9168~~
~~Depends on #9216~~

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

agreed on idea
agreed on implementation strategy
tests, as appropriate
- functional tests - tests/**.sh
- unit tests - src/*/tests
- integration tests - tests/nixos/*
documentation in the manual
documentation in the internal API docs
code and comments are self-explanatory
commit message explains why the change was made
new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

src/libexpr/primops/context.cc

roberth

Check that it's .drv
Docs need some work

tests/config.nix.in

src/libexpr/primops/context.cc

edolstra · 2023-08-04T11:56:30Z

Can you add a description of what the primop does to the PR motivation?

roberth · 2023-08-04T11:59:47Z

Can you add a description of what the primop does to the PR motivation?

I've added the three lines at the start.

Ericson2314 · 2023-08-04T20:34:31Z

Triaged in the Nix Team meeting this morning (n.b. I could not make it):

Needs to explain what it's about in the PR description
- @roberth has the context and can do, and now has done so.
Also needs to be discussed with the Nixpkgs architecture team to see whether they actually want that

Queued for discussion

nixos-discourse · 2023-08-08T15:29:36Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-08-08-nixpkgs-architecture-team-meeting-42/31454/1

nixos-discourse · 2023-08-09T05:14:23Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-08-04-nix-team-meeting-minutes-77/31487/1

tests/functional/lang/eval-fail-addDrvOutputDependencies-multi-elem-context.err.exp

tests/functional/lang/eval-fail-addDrvOutputDependencies-wrong-element-kind.err.exp

doc/manual/src/glossary.md

src/libexpr/primops/context.cc

tests/functional/config.nix.in

tests/functional/lang/eval-fail-addDrvOutputDependencies-multi-elem-context.err.exp

doc/manual/src/language/string-context.md

doc/manual/src/glossary.md

nixos-discourse · 2023-10-25T01:03:13Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-10-23-nix-team-meeting-minutes-97/34561/1

doc/manual/src/language/string-context.md

fricklerhandwerk

@Ericson2314 do you need help with that? I could quickly take it over if you like, as I have enough context and ideas to finish it. I need a bit more time to ramp up with the your store docs PRs.

Ericson2314 · 2023-11-08T15:30:51Z

@fricklerhandwerk I think it would be good to do the a deriving path page first, and then you take this over (and some things here can just reference that rather than include redundant material).

Ericson2314 · 2023-12-01T14:28:06Z

Draft because I wanted deriving paths to be documented first

fricklerhandwerk

I think it's pretty useful the way it is. In fact we could already add the glossary entry on deriving paths independently. If you want I can pick up the string contexts part from there and implement the suggestions myself.

doc/manual/src/glossary.md

doc/manual/src/language/string-context.md

Now what we have enough primops, we can document how string contexts work. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com> Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com> Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io> Co-authored-by: Felix Uhl <iFreilicht@users.noreply.github.com>

…dencies

all done

* Document string context Now what we have enough primops, we can document how string contexts work. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com> Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com> Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io> Co-authored-by: Felix Uhl <iFreilicht@users.noreply.github.com>

nixos-discourse · 2024-05-13T13:26:02Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-05-08-nix-team-meeting-minutes-144/45349/1

Ericson2314 requested a review from roberth June 27, 2023 16:18

github-actions bot added the tests label Jun 27, 2023

Ericson2314 commented Jun 27, 2023

View reviewed changes

src/libexpr/primops/context.cc Outdated Show resolved Hide resolved

Ericson2314 commented Jun 27, 2023

View reviewed changes

src/libexpr/primops/context.cc Outdated Show resolved Hide resolved

Ericson2314 commented Jun 27, 2023

View reviewed changes

src/libexpr/primops/context.cc Outdated Show resolved Hide resolved

Ericson2314 force-pushed the addDrvOutputDependencies branch 2 times, most recently from 1e5d5a7 to 3438db9 Compare June 27, 2023 16:26

Ericson2314 mentioned this pull request Jun 27, 2023

Get rid of the --derivation flag #8594

Draft

8 tasks

roberth added the language The Nix expression language; parser, interpreter, primops, evaluation, etc label Jul 1, 2023

Ericson2314 marked this pull request as ready for review July 9, 2023 18:34

Ericson2314 requested a review from edolstra as a code owner July 9, 2023 18:34

roberth reviewed Jul 14, 2023

View reviewed changes

github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jul 14, 2023

Ericson2314 force-pushed the addDrvOutputDependencies branch from 38040f8 to 8324fd8 Compare July 17, 2023 13:54

Ericson2314 marked this pull request as draft July 17, 2023 13:54

Ericson2314 mentioned this pull request Oct 11, 2023

Allow builtins.storePath in pure mode #5868

Open

Ericson2314 force-pushed the addDrvOutputDependencies branch from 8324fd8 to d934667 Compare October 13, 2023 05:06

Ericson2314 marked this pull request as ready for review October 13, 2023 05:06

Ericson2314 requested a review from fricklerhandwerk as a code owner October 13, 2023 05:06

thufschmitt self-assigned this Oct 13, 2023

Ericson2314 commented Oct 13, 2023

View reviewed changes

tests/functional/lang/eval-fail-addDrvOutputDependencies-multi-elem-context.err.exp Outdated Show resolved Hide resolved

Ericson2314 commented Oct 13, 2023

View reviewed changes

tests/functional/lang/eval-fail-addDrvOutputDependencies-wrong-element-kind.err.exp Outdated Show resolved Hide resolved

Ericson2314 commented Oct 16, 2023

View reviewed changes

doc/manual/src/glossary.md Outdated Show resolved Hide resolved

thufschmitt previously requested changes Oct 16, 2023

View reviewed changes

github-actions bot added the documentation label Oct 16, 2023

Ericson2314 unassigned thufschmitt Oct 23, 2023

iFreilicht reviewed Oct 23, 2023

View reviewed changes

doc/manual/src/glossary.md Outdated Show resolved Hide resolved

github-actions bot removed the documentation label Oct 25, 2023

fricklerhandwerk mentioned this pull request Nov 7, 2023

Add some docs on strings with context #9316

Draft

fricklerhandwerk reviewed Nov 7, 2023

View reviewed changes

doc/manual/src/language/string-context.md Outdated Show resolved Hide resolved

fricklerhandwerk reviewed Nov 7, 2023

View reviewed changes

doc/manual/src/language/string-context.md Outdated Show resolved Hide resolved

fricklerhandwerk reviewed Nov 7, 2023

View reviewed changes

Ericson2314 mentioned this pull request Nov 16, 2023

Document <drvPath>^<outputName> syntax for installables #9362

Closed

Ericson2314 marked this pull request as draft December 1, 2023 14:27

fricklerhandwerk reviewed Dec 1, 2023

View reviewed changes

Ericson2314 force-pushed the addDrvOutputDependencies branch from 2615e67 to 5f05df6 Compare December 20, 2023 08:09

fricklerhandwerk mentioned this pull request Apr 18, 2024

doc/glossary: Define output closure and runtime closure #8311

Merged

8 tasks

fricklerhandwerk added 2 commits May 8, 2024 21:55

review pass

8200024

review pass, reorder sections

65dbc95

fricklerhandwerk marked this pull request as ready for review May 8, 2024 20:25

fricklerhandwerk added the documentation label May 8, 2024

Ericson2314 added 2 commits May 8, 2024 16:26

Merge remote-tracking branch 'upstream/master' into addDrvOutputDepen…

7a5dc32

…dencies

Fix field order

d2b8bfc

fricklerhandwerk enabled auto-merge (squash) May 8, 2024 20:43

fricklerhandwerk approved these changes May 8, 2024

View reviewed changes

fricklerhandwerk merged commit b560521 into NixOS:master May 8, 2024

fricklerhandwerk mentioned this pull request May 14, 2024

Document string contexts #280

Closed

Ericson2314 deleted the addDrvOutputDependencies branch April 18, 2025 20:29

Uh oh!

Conversation

Ericson2314 commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Context

Checklist for maintainers

Priorities

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roberth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

edolstra commented Aug 4, 2023

Uh oh!

roberth commented Aug 4, 2023

Uh oh!

Ericson2314 commented Aug 4, 2023

Uh oh!

nixos-discourse commented Aug 8, 2023

Uh oh!

nixos-discourse commented Aug 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nixos-discourse commented Oct 25, 2023

Uh oh!

Uh oh!

Uh oh!

fricklerhandwerk left a comment

Choose a reason for hiding this comment

Uh oh!

Ericson2314 commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ericson2314 commented Dec 1, 2023

Uh oh!

fricklerhandwerk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nixos-discourse commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Ericson2314 commented Jun 27, 2023 •

edited

Loading

Ericson2314 commented Nov 8, 2023 •

edited

Loading

fricklerhandwerk left a comment •

edited

Loading