Merged
Conversation
- Remove some stray saved error messages that didn't correspond to any test, because they were renamed in d11faa0. - Need `--eval` in test failure test in order to get in "read-only" mode where we don't try to write to the store. (The other tests already do this.) - Need `--strict` so top-level attribute sets are still forced, like they are without `--eval`.
github-actions
bot
added
the
with-tests
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
…d-only Fix language tests a bit (cherry picked from commit e92cac7) Change-Id: I527e94c5af0921ff2559ce5a4ac7635be791c22e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove some stray saved error messages that didn't correspond to any test, because they were renamed in d11faa0.
Need
--evalin test failure test in order to get in "read-only" mode where we don't try to write to the store. (The other tests already do this.)Need
--strictso top-level attribute sets are still forced, like they are without--eval.Context
Priorities
Add 👍 to pull requests you find important.