Add builtins.addDrvOutputDependencies#9216
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Oct 23, 2023
Merged
Conversation
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
addDrvOutputDependencies-pre
branch
from
0917a49 to
845c771
Compare
8 tasks
End goal: make `(mkDerivation x).drvPath` behave like a non-DrvDeep context. Problem: users won't be able to recover the DrvDeep behavior when nixpkgs makes this change. Solution: add this primop. The new primop is fairly simple, and is supposed to complement other existing ones (`builtins.storePath`, `builtins.outputOf`) so there are simple ways to construct strings with every type of string context element. (It allows nothing we couldn't already do with `builtins.getContext` and `builtins.appendContext`, which is also true of those other two primops.) This was originally in NixOS#8595, but then it was proposed to land some doc changes separately. So now the code changes proper is just moved to this, and the doc will be done in that. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com> Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.nore github.com> Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io
Ericson2314
force-pushed
the
addDrvOutputDependencies-pre
branch
from
845c771 to
765436e
Compare
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
…encies-pre Add `builtins.addDrvOutputDependencies` (cherry picked from commit a58d7f1) Change-Id: Ia5a1790bf29dfaf29287cc35cdae6b6d650e7a83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
End goal: make
(mkDerivation x).drvPathbehave like a non-DrvDeep context.Problem: users won't be able to recover the DrvDeep behavior when nixpkgs makes this change.
Solution: add this primop.
The new primop is fairly simple, and is supposed to complement other existing ones (
builtins.storePath,builtins.outputOf) so there are simple ways to construct strings with every type of string context element.(It allows nothing we couldn't already do with
builtins.getContextandbuiltins.appendContext, which is also true of those other two primops.)Context
This was originally in #8595, but then it was proposed to land some doc changes separately. So now the code changes proper is just moved to this, and the doc will be done in that.
Progress towards #7910.
Priorities
Add 👍 to pull requests you find important.