Push getFSAccessor unsupported(...) down Store class hierarchy#8217
Merged
roberth merged 1 commit intoNixOS:masterfrom Apr 14, 2023
Merged
Conversation
More progress on issue NixOS#5729. Instead of having it by the default method in `Store` itself, have it be the implementation in `DummyStore` and `LegacySSHStore`. Then just the implementations which fail to provide the method pay the "penalty" of dealing with the icky `unimplemented` function for non-compliance. Combined with my other recent PRs, this finally makes `Store` have no `unsupported` calls!
github-actions
bot
added
the
store
roberth
approved these changes
Apr 14, 2023
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
This is safer by making explicit what is unsupported.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 18, 2024
…rchy Instead of having it be the default method in `Store` itself, have it be the implementation in `DummyStore` and `LegacySSHStore`. Then just the implementations which fail to provide the method pay the "penalty" of dealing with the icky `unimplemented` function for non-compliance. Picks up where NixOS#8217. Getting close to no `unsupported` in the `Store` interface itself! More progress on issue NixOS#5729.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
More progress on issue #5729.
Instead of having it by the default method in
Storeitself, have it be the implementation inDummyStoreandLegacySSHStore. Then just the implementations which fail to provide the method pay the "penalty" of dealing with the ickyunimplementedfunction for non-compliance.Context
Combined with my other recent PRs, this finally makes
Storehave nounsupportedcalls!Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.