Push addToStoreFromDump unsupported(...) down Store class hierarchy#9799
Merged
thufschmitt merged 1 commit intoNixOS:masterfrom Jan 18, 2024
Conversation
…rchy Instead of having it be the default method in `Store` itself, have it be the implementation in `DummyStore` and `LegacySSHStore`. Then just the implementations which fail to provide the method pay the "penalty" of dealing with the icky `unimplemented` function for non-compliance. Picks up where NixOS#8217. Getting close to no `unsupported` in the `Store` interface itself! More progress on issue NixOS#5729.
github-actions
bot
added
the
store
Member
|
Why do that for |
Member
Author
|
@thufschmitt My goal is to have no
So at this point I think it's fair to say this a "required method" that implementations must define. (And if they define it with |
thufschmitt
approved these changes
Jan 18, 2024
Member
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
That's fair :)
Let's merge then
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Sep 27, 2025
It should be the responsibility of implementations that don't implement it to say so. See also PR NixOS#9799, and issue NixOS#5729
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Sep 28, 2025
It should be the responsibility of implementations that don't implement it to say so. See also PR NixOS#9799, and issue NixOS#5729
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Sep 30, 2025
It should be the responsibility of implementations that don't implement it to say so. See also PR NixOS#9799, and issue NixOS#5729
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Sep 30, 2025
It should be the responsibility of implementations that don't implement it to say so. See also PR NixOS#9799, and issue NixOS#5729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of having it be the default method in
Storeitself, have it be the implementation inDummyStoreandLegacySSHStore. Then just the implementations which fail to provide the method pay the "penalty" of dealing with the ickyunimplementedfunction for non-compliance.Context
Picks up where #8217. Getting close to no
unsupportedin theStoreinterface itself!More progress on issue #5729.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.