Skip to content

Push getFSAccessor unsupported(...) down Store class hierarchy #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roberth merged 1 commit into from
Apr 14, 2023
Merged

Push getFSAccessor unsupported(...) down Store class hierarchy #8217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libstore/dummy-store.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ struct DummyStore : public virtual DummyStoreConfig, public virtual Store
void queryRealisationUncached(const DrvOutput &,
Callback<std::shared_ptr<const Realisation>> callback) noexcept override
{ callback(nullptr); }

virtual ref<FSAccessor> getFSAccessor() override
{ unsupported("getFSAccessor"); }
};

static RegisterStoreImplementation<DummyStore, DummyStoreConfig> regDummyStore;
Expand Down
3 changes: 3 additions & 0 deletions src/libstore/legacy-ssh-store.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,9 @@ struct LegacySSHStore : public virtual LegacySSHStoreConfig, public virtual Stor
void ensurePath(const StorePath & path) override
{ unsupported("ensurePath"); }

virtual ref<FSAccessor> getFSAccessor() override
{ unsupported("getFSAccessor"); }

void computeFSClosure(const StorePathSet & paths,
StorePathSet & out, bool flipDirection = false,
bool includeOutputs = false, bool includeDerivers = false) override
Expand Down
3 changes: 1 addition & 2 deletions src/libstore/store-api.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,7 @@ public:
/**
* @return An object to access files in the Nix store.
*/
virtual ref<FSAccessor> getFSAccessor()
{ unsupported("getFSAccessor"); }
virtual ref<FSAccessor> getFSAccessor() = 0;

/**
* Repair the contents of the given path by redownloading it using
Expand Down