nix-copy-closure: create LegacySSHStoreConfig directly #15197
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Feb 11, 2026
Merged
nix-copy-closure: create LegacySSHStoreConfig directly #15197Ericson2314 merged 2 commits intoNixOS:masterfrom
LegacySSHStoreConfig directly #15197Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
amaanq
force-pushed
the
ssh-store-config-direct
branch
3 times, most recently
from
9c0f1f2 to
8ba4f61
Compare
Ericson2314
reviewed
Feb 11, 2026
Stores hold their config as `ref<const Config>` or `const Config &`, so `Setting<>` fields are already immutable after store construction. The field-level `const` is redundant and prevents pre-construction mutation which is sometimes useful. This commit updates these settings by dropping the `const` qualifier, as it's not needed.
amaanq
force-pushed
the
ssh-store-config-direct
branch
from
8ba4f61 to
f1389ef
Compare
Instead of constructing a `StoreReference` and letting `openStore()` resolve it, this commit creates the store config directly and calls `openStore()` on it. This avoids the indirection through the store registry.
amaanq
force-pushed
the
ssh-store-config-direct
branch
from
f1389ef to
8020a84
Compare
Ericson2314
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of constructing a
StoreReferenceand lettingopenStore()resolve it, this commit creates the store config directly and callopenStore()on it. This avoids the indirection through the store registry.Motivation
Instead of constructing a
StoreReferenceand lettingopenStore()resolve it,create the store config directly and call
openStore()on it. This avoids theindirection through the store registry.
Context
This is a follow-up to #15195 (comment)
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.