globals: use StoreReference types in CLI argument handlers#15195
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 11, 2026
Merged
globals: use StoreReference types in CLI argument handlers#15195Ericson2314 merged 1 commit intoNixOS:masterfrom
StoreReference types in CLI argument handlers#15195Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
The CLI flags `--from`, `--to`, `--eval-store`, and substituter URIs now parse to `StoreReference` at the argument boundary. `fetchClosure` uses `StoreReference::parse` instead of `parseURL`. This also adds `operator<=>` to `StoreReference`.
github-actions
bot
added
new-cli
amaanq
changed the title
amaanq
changed the title
StoreReference types in CLI argument handlers
Ericson2314
reviewed
Feb 10, 2026
Comment on lines
+51
to
+57
| StoreReference remoteRef{ | ||
| .variant = StoreReference::Specified{.scheme = "ssh", .authority = sshHost}, | ||
| }; | ||
| if (gzip) | ||
| remoteRef.params["compress"] = "true"; | ||
| auto to = toMode ? openStore(StoreReference{remoteRef}) : openStore(); | ||
| auto from = toMode ? openStore() : openStore(StoreReference{remoteRef}); |
Member
There was a problem hiding this comment.
In another PR on top of this, lets see if we can go directly to creating SSHStore::Config and then calling the openStore method on it.
Ericson2314
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The CLI flags
--from,--to,--eval-store, and substituter URIs nowparse to
StoreReferenceat the argument boundary.fetchClosureusesStoreReference::parseinstead ofparseURL. This also addsoperator<=>toStoreReference.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.