store-config: remove unnecessary const from Setting<> fields#15200
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 11, 2026
Merged
store-config: remove unnecessary const from Setting<> fields#15200Ericson2314 merged 1 commit intoNixOS:masterfrom
const from Setting<> fields#15200Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
Stores hold their config as `ref<const Config>` or `const Config &`, so `Setting<>` fields are already immutable after store construction. The field-level `const` is redundant and prevents pre-construction mutation which is sometimes useful. This commit updates these settings by dropping the `const` qualifier, as it's not needed.
amaanq
force-pushed
the
remove-const-settings
branch
from
350f930 to
1add776
Compare
amaanq
changed the title
const from Setting<> fields
Ericson2314
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stores hold their config as
ref<const Config>orconst Config &, soSetting<>fields are already immutable after store construction. The field-levelconstis redundant and prevents pre-construction mutation which is sometimes useful. This commit updates these settings by dropping theconstqualifier, as it's not needed.Context
Needed to improve #15197 (comment)
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.