libstore: fix runtime gc on non-standard store paths#15122
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 30, 2026
Merged
libstore: fix runtime gc on non-standard store paths#15122Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
with-tests
Ericson2314
reviewed
Jan 30, 2026
Ericson2314
reviewed
Jan 30, 2026
Due to a typo in quoteRegexChars, finding runtime garbage collection roots was failing on paths that contained a dot, or any other regex chars that would have to be replaced. When fixing that error, also add tests to make sure gc continues to work.
Ericson2314
approved these changes
Jan 30, 2026
xokdvium
reviewed
Jan 31, 2026
| { | ||
| static auto specialRegex = boost::regex(R"([.^$\\*+?()\[\]{}|])"); | ||
| return boost::regex_replace(raw, specialRegex, R"(\$&)"); | ||
| return boost::regex_replace(raw, specialRegex, R"(\\$&)"); |
Contributor
There was a problem hiding this comment.
Hm, but what's the purpose of this with raw string literals?
Member
Author
There was a problem hiding this comment.
We need to escape the backslash for the regex engine, not the string parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Due to a typo in quoteRegexChars, finding runtime roots for garbage collection was failing on paths that contained a dot, or any other regex chars that would have to be replaced. This happened during functional tests.
At the same time, also add some tests to ensure that runtime gc continues to work. This was originally part of a change I wrote in lix: https://git.lix.systems/lix-project/lix/commit/c03de0df627864fb7e83e9af88201b8a5fcd4930
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.