Support gc-runtime functional tests in VMs#15123
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Jan 30, 2026
Merged
Conversation
Due to a typo in quoteRegexChars, finding runtime garbage collection roots was failing on paths that contained a dot, or any other regex chars that would have to be replaced. When fixing that error, also add tests to make sure gc continues to work.
This test insisted on placing profiles in NIX_STATE_DIR, but all packages were removed from the profile immediately after so they did not act as garbage collector roots. Switch to directly calling nix-build, allowing the test to run in VMs without NIX_STATE_DIR.
github-actions
bot
added
the
with-tests
Ericson2314
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is useful to make sure that gc works with an unprivileged daemon. it is also convenient to ensure that gc works on a full NixOS system in various configurations.
Context
This test insisted on placing profiles in
NIX_STATE_DIR, but all packages were removed from the profile immediately after so they did not act as garbage collector roots. Switch to directly callingnix-build, allowing the test to run in VMs withoutNIX_STATE_DIR.This PR relies on #15122, it should look cleaner once that is merged.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.