Split DerivationGoal in two #13181
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom May 21, 2025
Merged
Conversation
github-actions
bot
added
documentation
with-tests
This was referenced May 14, 2025
Merged
Ericson2314
force-pushed
the
derivation-building-goal
branch
2 times, most recently
from
a3b8b88 to
c45bd9b
Compare
Contributor
|
Is there an issue/do you plan to create something for the content addressed derivation regression you mentioned so it doesn't get lost? |
Member
Author
|
Yes once this is merged I would create an issue. I think the solution will fall out of the fix for #11928 (a separate, preexisitng issue), which is nice! |
|
🎉 All dependencies have been resolved ! |
Same technique as 6c2a7fd.
This separation of concerns is generally good, but in particular sets up for removing `addWantedOutputs` next.
Ericson2314
force-pushed
the
derivation-building-goal
branch
from
c45bd9b to
3b617e4
Compare
roberth
approved these changes
May 21, 2025
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Conditional on aforementioned issue being opened
Member
Author
|
#13247 here is the issue. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2025-05-21-nix-team-meeting-minutes-228/65204/1 |
roberth
added
the
backports rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This separation of concerns is generally good, but in particular sets up for removing
addWantedOutputsnext.The one regression it introduces is "upgrading" to all wanted output when a CA derivation is resolved but then substituted. That is not good, but content-addressing derivations are unstable, so I rather not block this. I am happy to fix that later, once this is done.
Context
Reworking the goals #12628
depends on Revert #77 #13176
depends on Remove
useDerivation#13177Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.