Merged
Conversation
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
revert-incomplete-closure-feature
branch
from
0156535 to
eb89e44
Compare
Ericson2314
force-pushed
the
revert-incomplete-closure-feature
branch
from
eb89e44 to
5b0ed7d
Compare
edolstra
reviewed
May 14, 2025
Ericson2314
force-pushed
the
revert-incomplete-closure-feature
branch
2 times, most recently
from
88f5e5e to
ea02e93
Compare
Ericson2314
commented
May 14, 2025
| In practice, however, we doubt even the more building is very likely to happen. | ||
| Remote stores that are missing dependencies in arbitrary ways (e.g. corruption) don't seem to be very common. | ||
|
|
||
| On the contrary, when remote stores fail to implement the [closure property](@docroot@/store/store-object.md#closure-property), it is usually an *intentional* choice on the part of the remote store, because it wishes to serve as an "overlay" store over another store, such as `https://cache.nixos.org`. |
Member
Author
There was a problem hiding this comment.
OK it's a link now. Thank you @Mic92 for merging the other PR so quickly!
…en retry the substituter" As summarized in NixOS#77 (comment) the motivation is that the complicated retry logic this introduced was making the cleanup task NixOS#12628 harder to accomplish. It was not easy to ascertain just what policy / semantics the extra control-flow was implementing, in order to figure out a different way to implementing it either. After talking to Eelco about it, he decided we could just....get rid of the feature entirely! It's a bit scary removing a decade+ old feature, but I think he is right. See the release notes for more explanation. This reverts commit 299141e. Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Ericson2314
force-pushed
the
revert-incomplete-closure-feature
branch
from
ea02e93 to
99cb85c
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
roberth
added
the
backports rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As summarized in
#77 (comment) the motivation is that the complicated retry logic this introduced was making the cleanup task #12628 harder to accomplish. It was not easy to ascertain just what policy / semantics the extra control-flow was implementing, in order to figure out a different way to implementing it either.
After talking to Eelco about it, he decided we could just....get rid of the feature entirely! It's a bit scary removing a decade+ old feature, but I think he is right. See the release notes for more explanation.
Context
In practice, when remote stores fail to implement the closure property (have object -> have all its dependencies), it is usually not due to arbitrary corruption, but due to the fact that the remote store was intended to act as an "overlay" store, often over
cache.nixos.org. In that case, the right fix is not do some sort of "franken-building" (as this feature implemented) but to make sure both substituters are configured.(In the future, we should make it easier for remote stores to indicate this to clients, to catch settings that won't work in general before a missing dependency is actually encountered.)
Any non-intentional case of stores missing dependencies, by contrast, I do not know about.
This reverts commit 299141e.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.