Restore dynamic derivations!#13186
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom May 21, 2025
Merged
Conversation
github-actions
bot
added
documentation
with-tests
Ericson2314
force-pushed
the
dyn-drv-without-new-goal-type
branch
4 times, most recently
from
e5b97db to
37b92ea
Compare
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
dyn-drv-without-new-goal-type
branch
2 times, most recently
from
a2a8ab8 to
82a6649
Compare
roberth
approved these changes
May 21, 2025
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Needs some dogfooding before merge, but other than that, this looks good to me!
This method does *not* create a new type of goal. We instead just make `DerivationGoal` more sophisticated, which is much easier to do now that `DerivationBuildingGoal` has been split from it (and so many fields are gone, or or local variables instead). This avoids the need for a secondarily trampoline goal that interacted poorly with `addWantedOutputs`. That, I hope, will mean the bugs from before do not reappear. There may in fact be a reason to introduce such a trampoline in the future, but it would only happen in conjunction with getting rid of `addWantedOutputs`. Restores the functionality (and tests) that was reverted in f4f28cd.
Ericson2314
force-pushed
the
dyn-drv-without-new-goal-type
branch
from
82a6649 to
57348b6
Compare
|
Third time's the charm |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2025-05-21-nix-team-meeting-minutes-228/65204/1 |
roberth
added
the
backports rejected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This method does not create a new type of goal. We instead just make
DerivationGoalmore sophisticated, which is much easier to do now thatDerivationBuildingGoalhas been split from it (and so many fields are gone, or or local variables instead).This avoids the need for a secondarily trampoline goal that interacted poorly with
addWantedOutputs. That, I hope, will mean the bugs from before do not reappear.Context
There may in fact be a reason to introduce such a trampoline in the future, but it would only happen in conjunction with getting rid of
addWantedOutputs.Restores the functionality (and tests) that was reverted in f4f28cd.
depends on #13181
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.