Factory reset #383
Merged
Factory reset #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
factory-reset
branch
from
b149b2e
to
2a7401e
Compare
4 tasks
|
Relevant nitropy PR: Nitrokey/pynitrokey#472 |
sosthene-nitrokey
force-pushed
the
factory-reset
branch
from
2a7401e
to
36db179
Compare
|
can you please rebase on top of main to make the tests work? + a |
sosthene-nitrokey
force-pushed
the
factory-reset
branch
3 times, most recently
from
d16dc8d
to
cf7ac5a
Compare
robin-nitrokey
approved these changes
Nov 17, 2023
Comment on lines
+372
to
+376
| assert!(should_preserve_file(path!("/fido/sec/00"))); | ||
| assert!(should_preserve_file(path!("/fido/x5c/00"))); | ||
| assert!(should_preserve_file(path!("/fido/sec/01"))); | ||
| assert!(should_preserve_file(path!("/fido/x5c/01"))); |
There was a problem hiding this comment.
please also add tests for the Trussed keys
nitrokey-3-firmware/components/provisioner-app/src/lib.rs
Lines 95 to 103 in 056b62c
We preserve all certificates, counters, and keys that have an id lower than 255. These IDs are the `Special` ids as defined by trussed
sosthene-nitrokey
force-pushed
the
factory-reset
branch
from
cf7ac5a
to
19e168a
Compare
|
Let me know what rom to test, I have a nk3 that would require full device factory reset. Otherwise HOTP cannot happen I I cannot reset secrets with nitropy. |
|
@tlaurion You should be able to do that with the next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full device factory reset functionality
Depends on