Handle reset signal from the admin app #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
admin-app-factory-reset
branch
2 times, most recently
from
af099a8
to
b8ba8f5
Compare
sosthene-nitrokey
force-pushed
the
admin-app-factory-reset
branch
from
b8ba8f5
to
ee932c0
Compare
| } | ||
| } | ||
| } | ||
|
|
||
| self.state.volatile.clear(self.backend.client_mut()); |
There was a problem hiding this comment.
Do we need this in the factory reset case in handle too? Maybe introduce a helper method reset_state?
There was a problem hiding this comment.
This clear method removes the private keys in volatile memory. Since the Factory Reset has already cleared all the filesystems, including the volatile, it will fail.
It was actually a mistake to do it after a factory reset.
src/card.rs
Outdated
Comment on lines
96
to
97
| self.state = State::default(); | ||
| reset_signal.ack_factory_reset(); |
There was a problem hiding this comment.
nit: We could also return after this because we don’t need to reset the state again.
src/state.rs
Outdated
| #[derive(Clone, Debug, Default, Eq, PartialEq)] | ||
| #[derive(Clone, Debug, Default)] |
There was a problem hiding this comment.
nit: no more need to remove the derives, but doesn’t make a difference
robin-nitrokey
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #187. Only the last commit matters.