Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for full device factory reset command #472

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

sosthene-nitrokey
Copy link
Contributor

This PR adds support for the full-device factory reset command introduced in Nitrokey/nitrokey-3-firmware#383

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

pynitrokey/nk3/admin_app.py Outdated Show resolved Hide resolved
pynitrokey/nk3/admin_app.py Outdated Show resolved Hide resolved
pynitrokey/cli/nk3/__init__.py Outdated Show resolved Hide resolved
pynitrokey/cli/nk3/__init__.py Outdated Show resolved Hide resolved
pynitrokey/nk3/admin_app.py Outdated Show resolved Hide resolved
pynitrokey/cli/nk3/__init__.py Outdated Show resolved Hide resolved
pynitrokey/cli/nk3/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not tested yet.

@sosthene-nitrokey sosthene-nitrokey merged commit cae3fc3 into master Nov 30, 2023
10 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the factory-reset branch November 30, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants