-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ctap-types and fido-authenticator #16
Update ctap-types and fido-authenticator #16
Conversation
This one is still draft, so I understand the review is not required yet? |
sneaks into your PRs |
@nickray That is definitely our intention and we share that goal. But there might be situations where we want to push out a release with functionality that is not yet accepted in upstream (as is the case here). That’s where we would use forks – with the goal to move back to the upstream crate as soon as possible. |
Our changes have been merged into the upstream crates, so we can now use them directly. I’m waiting for #20 before updating this PR to avoid dependency duplications. |
@robin-nitrokey PR #20 updated |
This patch updates the ctap-types and fido-authenticator dependencies to add support for the pin protocol field in the hmac-secret extension data so that the authenticatorGetAssertion command works with newer clients. Fixes Nitrokey#14.
36a9e17
to
c3c56c8
Compare
Updated and rebased onto nitrokey-main. @szszszsz Can you please review this? |
@@ -2,7 +2,16 @@ | |||
|
|||
## Bugfixes | |||
|
|||
- admin-app: Fix CTAPHID command dispatch (#8). | |||
- admin-app: Fix CTAPHID command dispatch ([#8][]). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I believe the format for the referenced link is just [link-name]
, not [link-name][]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shortcut only works in CommonMark, not in plain Markdown, see the Markdown spec.
This patch updates the ctap-types and fido-authenticator dependencies to
add support for the pin protocl field in the hmac-secret extension data
so that the authenticatorGetAssertion command works with newer clients.
Fixes #14.
This is a draft as it requires changes to the fido-authenticator (trussed-dev/fido-authenticator#1) and ctap-types (trussed-dev/ctap-types#2) dependencies. We can either wait for upstream to merge our changes or use forks instead.