Merge 7d1d9ec2bfae231ca4a7263a7e223db9fed51aa5 from solo2 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FILESYSTEM_BOUNDARY constant in the provisioner app is currently unused. The actual filesystem boundaries are defined in the build.rs file. To make the code easier to understand and to avoid confusion, this patch removes the unused constant.
Previously, the CTAPHID interface of the admin app did not handle the UUID command and interpreted all unknown commands as Wink commands. With this patch, we explicitly handle both the Wink and the UUID command and return an error if any other command is received.
This merge updates the dependencies specifications (no branch specification) to avoid duplicates and extracts the admin app into a separate crate.
szszszsz
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge of 7d1d9ec updates the dependencies specifications (no branch specification) to avoid duplicates and extracts the admin app into a separate crate.