Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ctap-types and fido-authenticator #16

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Update ctap-types and fido-authenticator #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion runners/lpc55/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,16 @@

## Bugfixes

- admin-app: Fix CTAPHID command dispatch (#8).
- admin-app: Fix CTAPHID command dispatch ([#8][]).
Copy link
Member

@szszszsz szszszsz Dec 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I believe the format for the referenced link is just [link-name], not [link-name][]

Copy link
Member Author

@robin-nitrokey robin-nitrokey Dec 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shortcut only works in CommonMark, not in plain Markdown, see the Markdown spec.

- fido-authenticator: Handle pin protocol field in hmac-secret extension data
to fix the authenticatorGetAssertion command for newer clients ([#14][],
[fido-authenticator#1][]).
- fido-authenticator: Signal credential protetection ([fido-authenticator#5][]).

[#8]: https://github.com/Nitrokey/nitrokey-3-firmware/issues/8
[#14]: https://github.com/Nitrokey/nitrokey-3-firmware/issues/14
[fido-authenticator#1]: https://github.com/solokeys/fido-authenticator/pull/1
[fido-authenticator#5]: https://github.com/solokeys/fido-authenticator/pull/5

# v1.0.0 (2021-10-16)

Expand Down
37 changes: 26 additions & 11 deletions runners/lpc55/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions runners/lpc55/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ log-debug = []
log-warn = []
log-error = []

# patch dependencies like so to test local changes

[profile.release]
codegen-units = 1
lto = true
Expand Down