fix(public): repair broken App Store citation on /audit (dogfood 78fcaed682fa) - #33
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 179cfff57d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "sources": [ | ||
| { "title": "Fiberygoodness - what is tinyStudio", "url": "https://www.fiberygoodness.com/whatistinystudio" }, | ||
| { "title": "TinyStudio - App Store", "url": "https://apps.apple.com/app/tinystudio" }, | ||
| { "title": "TinyStudio - App Store", "url": "https://apps.apple.com/us/app/tinystudio/id6448954288" }, |
There was a problem hiding this comment.
For this historical 2026-08-06 run, replacing the captured URL with a different canonical page corrupts the evidence: evidence-fixtures/ai-search/README.md requires every source URL to be recorded exactly as shown by the engine, and /audit.html promises readers the pages each engine cited. Unless the engine was rerun and actually returned this URL, keep the original URL in the fixture and solve the dead-link problem in the rendering layer, such as by displaying it without a link or storing a separate resolved link target; the new checker should not force historical observations to be rewritten.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce9b0ab66c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const host = parsedUrl.hostname.replace(/^www\./, ""); | ||
| if (host === "apps.apple.com" || host === "itunes.apple.com") { | ||
| const path = parsedUrl.pathname; | ||
| const carriesAppId = /^\/app\/\d+/.test(path) || /\/id\d+/.test(path); |
There was a problem hiding this comment.
When a future citation contains an ID-like substring in the wrong route, this check silently accepts it: for example, /foo/id6448954288, /us/not-app/tinystudio/id6448954288, and /app/6448954288garbage all make carriesAppId true even though none matches either supported form documented immediately above. Consequently, a structurally broken App Store link can still pass CI; validate the complete pathname rather than an unanchored substring or numeric prefix.
Useful? React with 👍 / 👎.
This branch sat open long enough for four other public-page PRs (#28 heading hierarchy, #30 apple touch icon, #32 schema.org, #33/#34 links) to land on the same five head sections and the same guard script, so every touched file conflicted. Resolution: all six conflicts were additive, not competing. - The five HTML files each gained a <link rel="canonical"> on this branch and icon/og/twitter/JSON-LD tags on main; both sets are kept. - scripts/check-site.mjs was rebuilt from main's version with this branch's 53-line canonical guard inserted verbatim before the migrations loop, rather than by textually merging two overlapping hunks — the first attempt at that spliced a dangling `const canonicalPages = [` and broke the file. intended-outcome: PR #29 becomes mergeable with the canonical guard and every already-landed head guard both enforced. verify: node scripts/check-site.mjs -> "TinyStudio.io checks passed."; npm test -> 15/15; npm run check, test:headings, test:worker all pass. check:render-blocking is not runnable here (playwright is not installed in this worktree) — CI covers it.
…current main and live (#94) The tracker item 'Ship origin/main past fa8d83c so merged PR #33 App Store citation goes live — /audit still embeds the 404 Apple URL' (scout 2026-08-09) was accepted by the fleet pipeline on 2026-08-09 (release-state advanced past fa8d83c to a163327 the same day, then kept shipping), but no closeout receipt was recorded on origin/main, so the tracker item stayed open. This lane re-verified the acceptance criteria against the current head and live (2026-08-11) and records the closeout so the item cannot re-open by drift: - release-state-tinystudio-io.json pins 354e725 (2026-08-11T03:38:32), strictly newer than fa8d83c and containing PR #33's fix commit aa64d7d. - Live /audit embeds exactly the id-carrying App Store citation (https://apps.apple.com/us/app/tinystudio/id6448954288) matching public/audit.html on origin/main; the fixed URL resolves 200 (301 regional redirect followed), the bare-slug baseline still 404. - git diff 354e725..origin/main -- public/ src/ scripts/ is empty: zero product-code changes pending; only docs receipts sit between the deployed release and main. - npm run check and full npm test pass on origin/main dc95ebf (90 tests, 0 failures).
…on current head and live (2026-08-15) (#223) Re-verified the finding on the current origin/main head (e35b4bf) and the deployed site, in the pattern of the 2026-08-11 closeout (PR #33) and the 2026-08-12/08-14 re-verifications: npm run check and npm test pass, the live /audit bundle is byte-identical to the fixtures (25 unique citation URLs), all 25 URLs resolve (23 at 200; Peerspace 403 and LinkedIn 999 are anti-bot walls, not dead links), and the dead bare-slug App Store form stays 404 and absent. The finding remains closed with no code change needed. Co-authored-by: nish3451 <nish3451@users.noreply.github.com> Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
1 participant
What
Closes dogfood finding 78fcaed682fa — "Broken external links on /audit.html" (audit run
20260808T074205Z-msk2fl3n, issue-19, severity warning).The dogfood engine found
apps.apple.com/app/tinystudioreturning 404 (724 B) on the audit page's rendered AI-search evidence table. That URL is the "TinyStudio - App Store" citation the q1-what-tinystudio-does/Google run carries — it is rendered as an outbound link bypublic/audit.js, so /audit.html shipped a dead external link, weakening the credibility of the supporting proof (the site sells link audits, so this is exactly the fault it flags for clients).Change
evidence-fixtures/ai-search/evidence.json— the citation URL is replaced with the live authoritative page:https://apps.apple.com/us/app/tinystudio/id6448954288. Verified 200 (Apple's canonical macOS App Store page for the same app — "TinyStudio — your AI subtitle generator", id 6448954288, developer site tinystudio.ai, matching the run's other citations). The bare-slug formapps.apple.com/app/tinystudiohas no region and no app id, which is why Apple serves 404 for it.public/audit.html— the embedded evidence bundle regenerated to match the fixture (the existing drift guard fails otherwise).scripts/check-site.mjs— new "External citation links (dogfood 78fcaed682fa)" section: any citation URL on the App Store family of hosts (apps.apple.com,itunes.apple.com) must carry an app id (/app/<numeric-id>or<region>/app/<slug>/id<digits>). This catches the exact broken shape offline, so CI never depends on the network.Verification
npm run check— passes; mutation-tested: reintroducinghttps://apps.apple.com/app/tinystudioin the fixture fails with "AI-search source URL is a dead App Store form"; reverting only the embed fails the drift guard; the valid id-only formapps.apple.com/app/6448954288passes (guard is not over-strict)npm test— 6/6 headings + 53/53 worker + 15/15 UI + site checks, all passnpm run check:render-blocking— all six pages PASS under the production CSP (real Chromium)wrangler deploy --dry-run— bundles cleanlyhttps://apps.apple.com/us/app/tinystudio/id6448954288resolves to the real TinyStudio App Store page (browser-verified)