fix(public): heading hierarchy cleanup on home and all six served pages - #28
Merged
Conversation
The dogfood audit (20260808T074205Z-msk2fl3n, finding e6e153bdadd0) flagged the home page's outline skipping levels: sections under h2 used h4 sub-headings. The same skip existed on agents, pricing and specimen (h1 -> h3 roster/findings, h2 -> h4 gatebox/stops/faq). Retag the sub-headings one level shallower so the native outline descends without gaps, retarget the affected CSS selectors with the same property values (appearance unchanged), and add a deterministic regression test (scripts/test-heading-hierarchy.mjs, wired into npm test) that locks the corrected outline per page and proves the checker rejects the pre-fix shapes.
…x served pages The earlier four-page cleanup (index, agents, pricing, specimen) left one heading-level skip of the same class on the sixth served page: brief-requested.html used h3 directly under the h1. Retag the three step headings to h2 and retarget .step h3 -> .step h2 in brief-requested.css with identical property values, so the rendered appearance is unchanged. Extend the regression test to all six served public pages (index, audit, agents, pricing, specimen, brief-requested — the worker's PUBLIC_ASSET_PATHS set) and lock their corrected outlines, plus prove the checker rejects the pre-fix brief-requested h1 -> h3 shape.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe public pages now use revised heading levels and matching CSS selectors. A heading hierarchy checker validates six pages and regression cases. The checker runs through a new npm script included in the main test workflow. ChangesPublic heading hierarchy
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@public/agents.css`:
- Line 19: Update the .gatebox h2 font-family declaration to use the unquoted
Fraunces family name while preserving the existing serif fallback.
In `@public/specimen.css`:
- Line 20: Update the .notrun h3 font-family declaration to use the unquoted
Fraunces family name, while preserving the existing serif fallback.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 784fe7b9-e4d6-4a26-b124-51cc6f7370f5
📒 Files selected for processing (12)
package.jsonpublic/agents.csspublic/agents.htmlpublic/brief-requested.csspublic/brief-requested.htmlpublic/index.csspublic/index.htmlpublic/pricing.csspublic/pricing.htmlpublic/specimen.csspublic/specimen.htmlscripts/test-heading-hierarchy.mjs
| .gatebox>div{padding:38px 42px} | ||
| .gatebox>div:first-child{border-right:1px solid var(--line)} | ||
| .gatebox h4{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em} | ||
| .gatebox h2{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em} |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the quotes from the Fraunces font family.
Stylelint reports font-family-name-quotes on Line 19. Remove the quotes while keeping the fallback family unchanged.
Proposed fix
- .gatebox h2{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em}
+ .gatebox h2{font-family:Fraunces,serif;font-weight:300;font-size:25px;letter-spacing:-.02em}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .gatebox h2{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em} | |
| .gatebox h2{font-family:Fraunces,serif;font-weight:300;font-size:25px;letter-spacing:-.02em} |
🧰 Tools
🪛 Stylelint (17.14.0)
[error] 19-19: Expected no quotes around "Fraunces" (font-family-name-quotes)
(font-family-name-quotes)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@public/agents.css` at line 19, Update the .gatebox h2 font-family declaration
to use the unquoted Fraunces family name while preserving the existing serif
fallback.
Source: Linters/SAST tools
| .notrun{margin-top:40px;background:rgba(176,74,46,.05);border:1px solid rgba(176,74,46,.22); | ||
| border-radius:10px;padding:26px 30px} | ||
| .notrun h4{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} | ||
| .notrun h3{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the quotes from the Fraunces font family.
Stylelint reports font-family-name-quotes on Line 20. Remove the quotes while keeping the fallback family unchanged.
Proposed fix
- .notrun h3{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)}
+ .notrun h3{font-family:Fraunces,serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .notrun h3{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} | |
| .notrun h3{font-family:Fraunces,serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} |
🧰 Tools
🪛 Stylelint (17.14.0)
[error] 20-20: Expected no quotes around "Fraunces" (font-family-name-quotes)
(font-family-name-quotes)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@public/specimen.css` at line 20, Update the .notrun h3 font-family
declaration to use the unquoted Fraunces family name, while preserving the
existing serif fallback.
Source: Linters/SAST tools
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cea7074e93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "public/agents.html", | ||
| "public/pricing.html", | ||
| "public/specimen.html", | ||
| "public/brief-requested.html" |
There was a problem hiding this comment.
This page list omits public/agent-desk.html, even though src/worker.js exposes both /agent-desk.html and /agent-desk through PUBLIC_ASSET_PATHS. Consequently, the new suite can report that every owned public page is protected while heading-level regressions on the Agent Desk pass unnoticed; add that HTML file and its expected outline to the gate.
Useful? React with 👍 / 👎.
nish3451
added a commit
that referenced
this pull request
Aug 9, 2026
Resolve the drift between fix/apple-touch-icon-home (finding 98a7bf8e08fc) and origin/main after #28 (heading hierarchy) and #31 (social share tags) landed. Both changes touched the same head regions and check-site.mjs; the merged result keeps the apple-touch-icon link and its regression guard alongside main's og:/twitter: share blocks on all five public pages.
This was referenced Aug 9, 2026
nish3451
added a commit
that referenced
this pull request
Aug 9, 2026
This branch sat open long enough for four other public-page PRs (#28 heading hierarchy, #30 apple touch icon, #32 schema.org, #33/#34 links) to land on the same five head sections and the same guard script, so every touched file conflicted. Resolution: all six conflicts were additive, not competing. - The five HTML files each gained a <link rel="canonical"> on this branch and icon/og/twitter/JSON-LD tags on main; both sets are kept. - scripts/check-site.mjs was rebuilt from main's version with this branch's 53-line canonical guard inserted verbatim before the migrations loop, rather than by textually merging two overlapping hunks — the first attempt at that spliced a dangling `const canonicalPages = [` and broke the file. intended-outcome: PR #29 becomes mergeable with the canonical guard and every already-landed head guard both enforced. verify: node scripts/check-site.mjs -> "TinyStudio.io checks passed."; npm test -> 15/15; npm run check, test:headings, test:worker all pass. check:render-blocking is not runnable here (playwright is not installed in this worktree) — CI covers it.
nish3451
added a commit
that referenced
this pull request
Aug 9, 2026
…nst current main and live (#40) The code-side fix (PR #28) and CI enforcement (scripts/test-heading-hierarchy.mjs, wired into npm test as test:headings) for dogfood finding e6e153bdadd0 ('Heading hierarchy needs cleanup on home') are already merged in origin/main. This lane re-verified the guarantee still holds after the subsequent page edits (canonical URLs, structured data, sitemap, internal-link cleanups): - npm run check passes on all six served public pages. - npm test passes (source checks + heading-hierarchy, sitemap, agent-worker and agent-UI suites). - Fresh live measurement of the deployed pages in real Chromium confirms the same: every served page carries exactly one h1 as its first heading and a gap-free descending outline — no h2->h4 or h1->h3 skips anywhere, including the home page the finding flagged.
This was referenced Aug 9, 2026
Merged
nish3451
added a commit
that referenced
this pull request
Aug 10, 2026
…and live (#92) The scout finding 'Ship origin/main past the stuck fleet-release SHA' (named PRs #28 heading hierarchy and #30 apple-touch-icon on main but not live) was already accepted by the fleet pipeline: the hourly release advanced release-state-tinystudio-io.json past the stuck eae1d87 to c5e2f2b on 2026-08-09, and the closeout receipt was prepared on branch docs/evidence/fleet-release-closeout but never merged to main. This lane re-verified the acceptance criteria against the current head and live (2026-08-11) and records the closeout on origin/main so the tracker item cannot re-open by drift: - release-state-tinystudio-io.json pins 354e725 (2026-08-11T03:38:32), strictly newer than the stuck eae1d87; pipeline actively shipping. - All six served pages serve exactly one leading h1, zero h4+, and gap-free outlines matching scripts/test-heading-hierarchy.mjs. - All five appraisal pages serve rel=apple-touch-icon; the asset returns 200 image/png; matches source (brief-requested is outside #30's scope in both source and live). - npm run check and full npm test pass on origin/main c934538 (90 tests, 0 failures); the live/main gap is exactly three docs(evidence) commits with zero public/ src/ scripts/ changes pending.
This was referenced Aug 11, 2026
Merged
Merged
nish3451
added a commit
that referenced
this pull request
Aug 12, 2026
…(PR #22 conflict-locked, superseded by #28) against current GitHub state (2026-08-12) (#152) Closes the review item "Two open PRs carry the same heading-hierarchy fix — PR #22 is conflict-locked and superseded" (review queue, unreviewed-by-grok), re-verified against the current GitHub state on 2026-08-12. Verified facts (2026-08-12): - PR #22 is CLOSED (2026-08-09), never merged, mergeStateStatus: DIRTY (conflict-locked) at close — the item's description was accurate. - The superseding fix PR #28 is MERGED on main (2026-08-09, commit 7be3d8f); sibling duplicate #27 is also CLOSED. - All 53 currently open PRs diff-reviewed: the only literal heading markup anywhere is one hierarchy-preserving h2 on /specimen in PR #107 (with its locked outline updated in scripts/test-heading-hierarchy.mjs) and one standalone h1 in PR #116's new closed-intake page — zero open PR retags an existing heading level, so no open PR duplicates the heading fix. - Main has carried exactly one heading fix since 2026-08-09: the only heading-tag change since the merge is 2ae7504's two hierarchy-preserving homepage FAQ h3s (PR #102, locked outline updated). npm run check passes and npm test passes in full (test:headings 6/6) on current origin/main (ad9cee3). - Site-side verification is current via docs/evidence/heading-hierarchy-2026-08-09.md (PR #74) with the 2026-08-12 re-verify in flight as PR #120. Docs-only change; no code, no deployment.
nish3451
added a commit
that referenced
this pull request
Aug 13, 2026
…and live (#139) The 2026-08-11 re-verification confirmed the closeout on head 354e725. Thirteen commits have landed since; the pipeline kept shipping every merge, so release-state-tinystudio-io.json now pins 18128e8 — byte-identical to the current origin/main HEAD, zero deployment lag (the 2026-08-11 receipt's docs-only lag is gone). Both named PRs (#28 7be3d8f heading hierarchy, #30 b004c11 apple-touch-icon) are ancestors of the deployed release; the stuck eae1d87 is strictly older. Live: all six served pages serve the locked gap-free heading outlines (home now 30 items incl. PR #102's two FAQ h3s), all five appraisal pages serve rel=apple-touch-icon resolving 200 image/png. npm run check passes; npm test passes 92/92 on this head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Dogfood finding e6e153bdadd0 ("Heading hierarchy needs cleanup on home", audit 20260808T074205Z-msk2fl3n): the home page's native outline skips levels — sections under an
h2usedh4sub-headings. The same skip classes exist on the sibling served pages (h1 -> h3roster/findings/brief-requested steps,h2 -> h4gatebox/stops/FAQ).This change retags the sub-headings one level shallower so every outline descends without gaps (
h1 -> h2 -> h3), retargets the affected CSS selectors with the same property values (rendered appearance unchanged), and adds a deterministic regression test (scripts/test-heading-hierarchy.mjs, wired intonpm test) that locks the corrected outline of all six served public pages and proves the checker rejects the pre-fix shapes.Files
public/index.html— home:.stopand.qsub-headingsh4 -> h3(the finding's page)public/agents.html— rosterh3 -> h2, gateboxh4 -> h2public/pricing.html— stops/FAQh4 -> h3public/specimen.html— findingsh3 -> h2, not-run noteh4 -> h3public/brief-requested.html— stepsh3 -> h2(the one page the earlier four-page attempt missed)public/{index,agents,pricing,specimen,brief-requested}.css— selector retargets, values unchangedpackage.json,scripts/test-heading-hierarchy.mjs— regression gate covering all six pages in the worker'sPUBLIC_ASSET_PATHSset (index, audit, agents, pricing, specimen, brief-requested)Relationship to the open attempts
fix/heading-hierarchy-cleanup) fixes the four-page subset and is the basis for the first commit here (identical content, freshly cherry-picked onto currentorigin/main).fix/heading-hierarchy) is the earlier attempt, now merge-conflicting.brief-requested.html(anh1 -> h3skip — the exact class fix(public): remove heading-level skips on home and sibling pages #27's own description says it fixed on siblings), with the test extended to all six served pages. PRs fix(public): repair heading hierarchy without visual changes #22 and fix(public): remove heading-level skips on home and sibling pages #27 can be closed.Verification (local, fresh origin/main base)
npm run check— passnpm test— 74/74 pass (check + 6 heading-hierarchy + 53 worker + 15 UI)git diff --check— cleansgscan— no new security findingsnpm run check:render-blocking— 6/6 PASS (real Chromium, production CSP)npx wrangler deploy --dry-run— okRepository proof only (heading hierarchy + tests, locally verified). No live-deployment, ranking, or accessibility-certification claim; no deploy or merge here.
Summary by CodeRabbit
Accessibility
Bug Fixes
Tests