docs(evidence): close out duplicate heading-hierarchy PR review item (PR #22 conflict-locked, superseded by #28) - #51
Conversation
…against current GitHub state
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
📝 WalkthroughWalkthroughThe PR adds a verification receipt for duplicate heading-hierarchy PRs. It records their states, supersession findings, merged-fix evidence, regression coverage, validation results, retained branches, and review closure. ChangesHeading-hierarchy verification
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/evidence/duplicate-heading-prs-2026-08-09.md`:
- Around line 4-5: Reflow the sentence in the document’s “Scope” text so “PR
`#22`” does not begin a line, preserving the existing wording while keeping the
Markdown heading lint check satisfied.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 2ceea15e-5ce3-4c96-9569-444ed3e31c57
📒 Files selected for processing (1)
docs/evidence/duplicate-heading-prs-2026-08-09.md
| Scope: the review item "Two open PRs carry the same heading-hierarchy fix — PR | ||
| #22 is conflict-locked and superseded" (review queue, unreviewed-by-grok), |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Reflow PR #22`` to satisfy Markdown lint.
markdownlint-cli2 reports MD018 because #22 starts a new line. Keep PR #22`` on the preceding line or escape the hash.
Proposed fix
-Scope: the review item "Two open PRs carry the same heading-hierarchy fix — PR
-#22 is conflict-locked and superseded" (review queue, unreviewed-by-grok),
+Scope: the review item "Two open PRs carry the same heading-hierarchy fix — PR `#22`
+is conflict-locked and superseded" (review queue, unreviewed-by-grok),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Scope: the review item "Two open PRs carry the same heading-hierarchy fix — PR | |
| #22 is conflict-locked and superseded" (review queue, unreviewed-by-grok), | |
| Scope: the review item "Two open PRs carry the same heading-hierarchy fix — PR `#22` | |
| is conflict-locked and superseded" (review queue, unreviewed-by-grok), |
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 5-5: No space after hash on atx style heading
(MD018, no-missing-space-atx)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/evidence/duplicate-heading-prs-2026-08-09.md` around lines 4 - 5, Reflow
the sentence in the document’s “Scope” text so “PR `#22`” does not begin a line,
preserving the existing wording while keeping the Markdown heading lint check
satisfied.
Source: Linters/SAST tools
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16f4469573
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| PRs (`fix/heading-hierarchy`, `fix/heading-hierarchy-cleanup`) still exist | ||
| on origin. This repository routinely retains branches of closed PRs | ||
| (several older closed-PR branches remain on origin), and deleting them is | ||
| outside this lane's scope; they have no open PR and cannot be merged. |
There was a problem hiding this comment.
Describe the retained branches as inactive, not unmergeable
Because these branches explicitly still exist on origin, their commits can still be merged directly or through a reopened/new pull request; closing the existing PRs only means there is currently no open merge request. The statement that they “cannot be merged” therefore overstates the closeout and should be replaced with the narrower, already-supported claim that neither branch has an open PR.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c84a0dde83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| the same heading-hierarchy fix. The two duplicates are closed and the | ||
| canonical fix is merged. | ||
| 2. The item's description of PR #22 was accurate: it was conflict-locked | ||
| (`DIRTY`/`CONFLICTING`, never mergeable) and it was superseded — its own |
There was a problem hiding this comment.
Limit the mergeability claim to the observed snapshot
When this receipt is used as historical evidence, never mergeable claims more than the recorded verification establishes: the table only reports DIRTY/CONFLICTING at close, which does not prove that PR #22 was unmergeable throughout its lifetime. Preserve the at-close qualification here or provide evidence covering the PR's full history.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54432c1386
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Every pull request that carries or carried the heading-hierarchy fix, in | ||
| order of creation: |
There was a problem hiding this comment.
Label PR #40 as closeout evidence, not a fix carrier
The claimed exhaustive set is inaccurately defined: PR #40 only added docs/evidence/heading-hierarchy-2026-08-09.md, while the code fix and regression test had already landed in PR #28. Including #40 under “Every pull request that carries or carried the heading-hierarchy fix” makes this process receipt misclassify an evidence-only PR; describe the table as all related fix and closeout PRs, or move #40 to a separate closeout-evidence entry.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b4fb62e6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| This closes the review item "Two open PRs carry the same heading-hierarchy | ||
| fix — PR #22 is conflict-locked and superseded" against current GitHub | ||
| state: the duplicate open PRs are closed, the conflict-locked PR #22 was | ||
| superseded by the merged PR #28, and no open PR currently duplicates the |
There was a problem hiding this comment.
Reconcile the already-merged superseding closeout
Landing this closeout leaves contradictory evidence in the repository: the commit's parent already contains docs/evidence/duplicate-heading-prs-2026-08-11.md, which explicitly says this 2026-08-09 receipt was never merged, that its five-PR snapshot is stale, and that the newer receipt supersedes it. This commit now tracks that stale receipt and again declares the item closed without updating the newer document, making its provenance and current-state assertions false; remove this receipt or reconcile both documents to identify one authoritative closeout.
Useful? React with 👍 / 👎.
intended-outcome: Close the review item "Two open PRs carry the same heading-hierarchy fix — PR #22 is conflict-locked and superseded" against current GitHub state, with a verifiable receipt in the repo's evidence convention.
Verification on 2026-08-09:
fix/heading-hierarchy): CLOSED, never merged, was conflict-locked (DIRTY/CONFLICTING) at close — exactly as the item described.fix/heading-hierarchy-cleanup): the sibling duplicate, CLOSED, never merged.fix/heading-hierarchy-complete): MERGED into main 2026-08-09 — the superseding fix, with regression testscripts/test-heading-hierarchy.mjswired intonpm testastest:headings.docs/evidence/heading-hierarchy-2026-08-09.md).h1–h6, so no open PR carries the heading fix today.Current main verified in this lane:
npm run checkpasses;npm testpasses in full, includingtest:headings6/6.Repository proof only: GitHub PR-state evidence and local test runs. No live measurement, ranking, or accessibility-certification claim is made beyond the already-merged receipt (PR #40). No deployment or merge in this change.
Summary by CodeRabbit