Repository navigation
Localize Capture shortcuts and save feedback in seven languages - #473
Merged
NewWorldVenture merged 1 commit intoSep 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 10, 2026
NewWorldVenture
marked this pull request as ready for review
September 10, 2026 00:49
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture's shortcut destinations, hints, picker titles and accessibility labels still appeared in English. They now follow the selected language across all 40 shortcuts and all seven primary locales, including the page title, empty state, count and save feedback. A rejected save request shows the translated error without exposing transport diagnostics.
Shortcut IDs, icons, destinations, selection limits, preference payloads, cache behavior and access guards are preserved. Custom headings remain caller-supplied. Unused English catalog metadata was removed after confirming there are no external consumers; the household-move label has its own translation instead of reusing a generic movement verb. No shared navigation or SQL changes.
Validation: 58 focused Capture tests plus 55 catalogue integrity tests, root TypeScript, scoped ESLint, all eight i18n gates, zero scoped translation-scan findings and clean diff. The rendering/callback tests cover seven locales, all destinations, picker replacement/removal, limits, navigation, custom/hidden headings, controlled editing, resolved/rejected save failures and page metadata/authentication. Portal focus and real browser interaction are outside these SSR/callback tests.
Ready for owner integration. At exact head 14905de, CI run 34422127647 passed core Typecheck/Lint/Test/Build, Mobile Expo Typecheck/Config, database migration replay/RLS probes, and E2E public/accessibility/authenticated/mobile-device checks. Vercel deployment also succeeded; Supabase Preview was skipped.
This main-based branch retains the existing Windows path issue in the separate i18n-server-boundary test; #457 and the auth integration already correct it. Combined integration validation remains separate from this PR's successful final-head checks.