Skip to content

Filter Files folders by category identity - #468

Closed
NewWorldVenture wants to merge 1 commit into
codex/strategy-files-hub-localization-20260909from
codex/strategy-files-category-filter-20260909
Closed

NewWorldVenture wants to merge 1 commit into
codex/strategy-files-hub-localization-20260909from
codex/strategy-files-category-filter-20260909

Conversation

@NewWorldVenture

Copy link
Copy Markdown
Owner

Selecting the generated General folder hid uncategorized files because it searched for the word General instead of matching an empty category. Folder groups now retain a null identity for missing/blank categories, display a translated Uncategorized label, and keep an authored category named General separate.

Folder selection compares category strings directly. Free-text search then narrows that selection; selecting another folder resets the search, and All Files clears both. Names containing quotes, commas, brackets, percent signs or other syntax remain literal. Selection is scoped to its household and Cloud/Vault/Shared view. Existing grouping normalization is preserved: surrounding whitespace is trimmed, blank becomes null, and case remains significant for category identity. Stored values and upload/service behavior are unchanged.

Stacked on #465 (cc470430); this diff is the separate runtime correction described there. One new label in all seven base locales. No SQL or sidebar changes.

Validation:

  • 167 focused tests across five suites pass, including actual seven-locale selection/search/clear behavior, General/null separation, syntax characters, context changes, disappearance of a selected category, stored-row immutability and the existing upload refusal checks.
  • Root independently reviewed the change and reran 83 actual UI/overview tests successfully.
  • Changed-file lint, all eight i18n gates, zero-literal scan and diff check pass. Native TypeScript passes.
  • The required i18n server-boundary suite has five passes and the two pre-existing Windows path failures, fixed separately by Make repository audits work on Windows and POSIX #457. No test was skipped or weakened. Per the bounded validation scope, no additional full suite or production build was run for this follow-up.

Coordination: #421 (claim comment 5610172031).

@vercel

vercel Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bubaly Ready Ready Preview Sep 9, 2026 11:33pm UTC

Request Review

Copy link
Copy Markdown
Owner Author

Shipped — this landed on main in #500 (merge commit f478dce5).

It stayed open only because its base is codex/strategy-files-hub-localization-20260909, a stacked branch that never moved, so the auto-close-on-merge never applied. Retargeting it to main is refused by GitHub with "There are no new commits between base branch 'main' and head branch 'codex/strategy-files-category-filter-20260909'" — which is the confirmation that every commit here is already in main.

Closing as redundant, not rejected.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
Preview — d0169e7d Deployed Sep 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant