Skip to content

Localize Files hub controls and upload feedback - #465

Merged
NewWorldVenture merged 1 commit into
mainfrom
codex/strategy-files-hub-localization-20260909
Sep 10, 2026
Merged

NewWorldVenture merged 1 commit into
mainfrom
codex/strategy-files-hub-localization-20260909

Conversation

@NewWorldVenture

Copy link
Copy Markdown
Owner

Cloud Storage, Secure Vault and Shared Files still displayed English headings, upload/refusal feedback and icon labels. This change localizes the Files hub and its three page titles in all seven base locales, including file sizes, counts and dates. View descriptions now reflect the existing parent/adult restrictions on secure files and sensitive categories.

Default storage folders remain cloud, vault and shared; authored titles/categories remain data, including a category literally named General. Generated fallback labels are marked for display translation without becoming search or storage identities. The existing upload coordinator receives an explicit translator while keeping refusal before storage, secure/shared flags, effect order and failed-insert cleanup. Feature and AAL2 entry checks remain intact. No upload redesign, schema or sidebar changes.

Validation:

  • Independent review is clear; the reviewer separately reran 87 relevant tests across three suites, including the actual Files form and upload refusal paths.
  • 156 focused tests across five suites pass, including actual seven-locale component/form rendering and the real upload coordinator with mocked storage boundaries. Coverage includes every view and metadata page, role refusals, original folder/category payloads, accessible action names, confirmations, file-size feedback, dates/counts and failed-insert cleanup.
  • Changed-file lint, all eight i18n gates, zero-literal scan and diff check pass. Native TypeScript passes. Full suite: 9,607 tests pass, with the six inherited Windows guard failures in five suites (household-trail 1, i18n-server-boundary 2, supabase-query-audit 1, untrusted-fence-ratchet 1, metadata-title-not-catalogue-key 1). Separate PR Make repository audits work on Windows and POSIX #457 addresses those; this branch does not alter their assertions.
  • Tests do not claim authenticated database/storage or live browser permission verification.

Based on main 593867d5; no production-file overlap with #449, #451 or #458. Thirty-three scoped keys per base locale; German, French and Portuguese use formal address.

Deferred existing issue, intentionally outside this translation change: a document named Receipt.pdf with category: null produces a General folder chip. Clicking it sets search to the machine string General, which cannot match the null category, so the row disappears. A separate runtime fix should filter uncategorized rows by category identity instead of searching a display label; this PR preserves the existing grouping and search behavior.

Coordination: #421 (claim comment 5610042301).

@vercel

vercel Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bubaly Ready Ready Preview Sep 9, 2026 11:28pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — cc470430 Deployed Sep 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant