chore: sync skills (CUDA-Q,cuOpt,TensorRT-LLM,Model-Optimizer,Megatron-Bridge,Nemotron Voice Agent,NeMo Gym,NeMo Evaluator) - #21
Conversation
2dfc8e8 to
d00bec7
Compare
af9de4c to
6ad904c
Compare
6ad904c to
b7712aa
Compare
|
Reviewed the sync output — looks good overall. 277 files across 7 product directories, all under One thing to check before merging: cuOpt and Nemotron Voice Agent are listed in the PR body as synced but don't appear in the file diff. Looks like the sparse checkout may have failed silently for those repos. Could be a PAT access issue or a path mismatch in
Everything else LGTM — happy to approve once the missing products are resolved or confirmed as expected. |
Review CommentsThe workflow refactor to 1. Internal URL — NeMo Evaluator Launcher
If this repo goes public, this should be replaced with a placeholder or marked as internal-only. 2. Internal Infrastructure URLs — TensorRT-LLM
These are in slurm/compile skills which may be internal-use-only, but they'd leak internal infra details if the repo goes public. 3. Author Email — CUDA-Q
4. Megatron-Core — No Skills Synced
|
…n-Bridge,Nemotron Voice Agent,NeMo Gym,NeMo Evaluator)
b7712aa to
5aeb32f
Compare
|
Great catches, @mosheabr! Thanks for the thorough review! Addressing each: 1-3 (Internal URLs, email in CUDA-Q): These are valid concerns but they live in the source repos (NeMo Evaluator, TensorRT-LLM, CUDA-Q), not in this catalog. The sync workflow mirrors skills as-is from each product repo — we don't modify content during sync. 4 (Megatron-Core): Confirmed — .claude/skills in NVIDIA/Megatron-LM is a symlink pointing to ../skills, not an actual directory. Sparse checkout pulls the symlink file instead of the directory contents, so the sync silently skips it. We have a fix in PR #24 that tracks and reports failed components — once merged, this will automatically create a GitHub issue when Megatron-Core fails to sync, making it visible instead of silent. The Megatron team will need to update their entry in components.yml to use the correct path. |
mosheabr
left a comment
There was a problem hiding this comment.
LGTM — approving. The internal URL issues (items 1-3) live in the source repos, not this catalog. Let's file issues on the respective source repos for the owning teams to clean up:
- NeMo Evaluator:
gitlab-master.nvidia.comcontainer registry URL - TensorRT-LLM:
urm.nvidia.comandauthn.nvidia.comreferences - CUDA-Q: author email in SKILL.md metadata
Megatron-Core symlink issue is tracked via the failure reporting in PR #24 (now merged).
Automated skills sync
Components synced:
Components that failed to sync:
.claude/skills/empty or missingTriggered by:
workflow_dispatch