Skip to content

Track and report components that fail to sync - #24

Merged
sayalinvidia merged 1 commit into
NVIDIA:mainfrom
sayalinvidia:add-sync-failure-tracking
Apr 17, 2026
Merged

Track and report components that fail to sync#24
sayalinvidia merged 1 commit into
NVIDIA:mainfrom
sayalinvidia:add-sync-failure-tracking

Conversation

@sayalinvidia

Copy link
Copy Markdown
Collaborator

Summary

  • Log failed components with reason (clone failed or path empty/missing)
  • Include failed components in the sync PR body so reviewers see what was skipped
  • Open a GitHub issue listing failed components when the overall sync succeeds but some were skipped
  • Existing total-failure issue (when nothing syncs) is unchanged

Example PR body with failures

Components synced:

  • CUDA-Q
  • cuOpt
  • TensorRT-LLM

Components that failed to sync:

  • Megatron-Core (NVIDIA/Megatron-LM): .claude/skills/ empty or missing

Test plan

  • Tested on sayali-skills-test — Megatron-Core correctly reported as failed, issue created

- Log failed components to a separate file with reason (clone failed
  or path empty/missing)
- Include failed components in the sync PR body so they are visible
- Open a GitHub issue listing failed components when the overall sync
  succeeds but some components were skipped
- Keep the existing total-failure issue for when nothing syncs at all

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sayalinvidia
sayalinvidia requested a review from mosheabr as a code owner April 17, 2026 18:21
@sayalinvidia

Copy link
Copy Markdown
Collaborator Author

example issue created verified on a test repo:

image

@mosheabr mosheabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Clean implementation — two failure modes correctly captured (clone failed vs. path empty/missing), failed components surfaced in the PR body for reviewers, and a separate issue created with the sync-failure label for tracking.

This directly addresses the Megatron-Core silent failure we saw in PR #21. Nice work testing it on the test repo first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants