Don't skip debug tests when LTO enabled by default#311
Merged
kkraus14 merged 1 commit intoNVIDIA:mainfrom Jun 27, 2025
Merged
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
gmarkall
added
3 - Ready for Review
These used to be skipped when LTO was enabled because it was unconditionally enabled, even for kernels where `debug=True`. Now if `debug=True` LTO is disabled, so it is not a problem to run the debug tests even when LTO is enabled. This fixes something of a regression in our test coverage, where these tests were run in fewer settings due to LTO being enabled by default.
gmarkall
force-pushed
the
no-lto-debug-skip
branch
from
be4692b to
816ff5c
Compare
Contributor
Author
|
/ok to test |
kkraus14
approved these changes
Jun 27, 2025
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
Jul 2, 2025
- Updates for recent API changes (NVIDIA#313) - Fix lineinfo generation when compile_internal used (NVIDIA#271) (NVIDIA#287) - Build docs with NVIDIA Sphinx theme (NVIDIA#312) - Don't skip debug tests when LTO enabled by default (NVIDIA#311) - Use `cuda.bindings` and `cuda.core` for `Linker` (NVIDIA#133) - Enable LTO by default when pynvjitlink is available (NVIDIA#310)
Merged
gmarkall
added a commit
that referenced
this pull request
Jul 2, 2025
- Updates for recent API changes (#313) - Fix lineinfo generation when compile_internal used (#271) (#287) - Build docs with NVIDIA Sphinx theme (#312) - Don't skip debug tests when LTO enabled by default (#311) - Use `cuda.bindings` and `cuda.core` for `Linker` (#133) - Enable LTO by default when pynvjitlink is available (#310)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These used to be skipped when LTO was enabled because it was unconditionally enabled, even for kernels where
debug=True. Now ifdebug=TrueLTO is disabled, so it is not a problem to run the debug tests even when LTO is enabled.This fixes something of a regression in our test coverage, where these tests were run in fewer settings due to LTO being enabled by default.