Skip to content

Don't skip debug tests when LTO enabled by default #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkraus14 merged 1 commit into from
Jun 27, 2025
Merged

Don't skip debug tests when LTO enabled by default #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions numba_cuda/numba/cuda/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@ def tearDown(self):
config.CUDA_LOW_OCCUPANCY_WARNINGS = self._low_occupancy_warnings
config.CUDA_WARN_ON_IMPLICIT_COPY = self._warn_on_implicit_copy

def skip_if_lto(self, reason):
# Some linkers need the compute capability to be specified, so we
# always specify it here.
cc = devices.get_context().device.compute_capability
linker = driver._Linker.new(cc=cc)
if linker.lto:
self.skipTest(reason)


class ContextResettingTestCase(CUDATestCase):
"""
Expand Down
9 changes: 0 additions & 9 deletions numba_cuda/numba/cuda/tests/cudapy/test_debuginfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@ class TestCudaDebugInfo(CUDATestCase):
These tests only checks the compiled PTX for debuginfo section
"""

def setUp(self):
super().setUp()
# If we're using LTO then we can't check the PTX in these tests,
# because we produce LTO-IR, which is opaque to the user.
# Additionally, LTO optimizes away the exception status due to an
# oversight in the way we generate it (it is not added to the used
# list).
self.skip_if_lto("Exceptions not supported with LTO")

def _getasm(self, fn, sig):
fn.compile(sig)
return fn.inspect_asm(sig)
Expand Down
6 changes: 0 additions & 6 deletions numba_cuda/numba/cuda/tests/cudapy/test_exception.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@


class TestException(CUDATestCase):
def setUp(self):
super().setUp()
# LTO optimizes away the exception status due to an oversight
# in the way we generate it (it is not added to the used list).
self.skip_if_lto("Exceptions not supported with LTO")

def test_exception(self):
def foo(ary):
x = cuda.threadIdx.x
Expand Down
4 changes: 0 additions & 4 deletions numba_cuda/numba/cuda/tests/cudapy/test_fastmath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,6 @@ def test_divf(self):
)

def test_divf_exception(self):
# LTO optimizes away the exception status due to an oversight
# in the way we generate it (it is not added to the used list).
self.skip_if_lto("Exceptions not supported with LTO")

def f10(r, x, y):
r[0] = x / y

Expand Down
7 changes: 0 additions & 7 deletions numba_cuda/numba/cuda/tests/cudapy/test_userexc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,6 @@ class MyError(Exception):


class TestUserExc(CUDATestCase):
def setUp(self):
super().setUp()
# LTO optimizes away the exception status due to an oversight
# in the way we generate it (it is not added to the used list).
# See https://github.com/numba/numba/issues/9526.
self.skip_if_lto("Exceptions not supported with LTO")

def test_user_exception(self):
@cuda.jit("void(int32)", debug=True, opt=False)
def test_exc(x):
Expand Down