Enable LTO by default when pynvjitlink is available#310
Enable LTO by default when pynvjitlink is available#310gmarkall merged 2 commits intoNVIDIA:mainfrom
Conversation
Enabling LTO by default when pynvjitlink is available should: - Provide a general improvement in performance for various use cases, particularly those linking external code. This ought to be benchmarked, but I'm making an assumption that it helps for now based on prior anecdotal / informal experience. - Make the case where users link LTO-IR to kernels or as part of device function declarations "just work" as long as pynvjitlink is installed. A further improvement would still be to error out when a users tries to link LTO-IR when pynvjitlink is not installed - that is left to be done in a future PR.
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
This looks like it'll fix the recent cuda.coop issues I ran into, so, +1 from me. |
|
Looking into the failures here |
|
To fix the simulator test we need to add |
Actually I think it's just https://github.com/NVIDIA/numba-cuda/pull/310/files#r2167468144 |
Also skip an irrelevant test on cudasim.
|
/ok to test |
- Updates for recent API changes (NVIDIA#313) - Fix lineinfo generation when compile_internal used (NVIDIA#271) (NVIDIA#287) - Build docs with NVIDIA Sphinx theme (NVIDIA#312) - Don't skip debug tests when LTO enabled by default (NVIDIA#311) - Use `cuda.bindings` and `cuda.core` for `Linker` (NVIDIA#133) - Enable LTO by default when pynvjitlink is available (NVIDIA#310)
- Updates for recent API changes (#313) - Fix lineinfo generation when compile_internal used (#271) (#287) - Build docs with NVIDIA Sphinx theme (#312) - Don't skip debug tests when LTO enabled by default (#311) - Use `cuda.bindings` and `cuda.core` for `Linker` (#133) - Enable LTO by default when pynvjitlink is available (#310)
3 participants
Enabling LTO by default when pynvjitlink is available should:
A further improvement would still be to error out when a users tries to link LTO-IR when pynvjitlink is not installed - that is left to be done in a future PR.