Build and test with CUDA 13.3.0 - #8246
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates devcontainer configs, CI workflow references, conda environment specs, dependency matrices, and docs to replace CUDA 13.2 with CUDA 13.3 across the repository. ChangesCUDA 13.3 infrastructure update
🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 147: Update the CONTRIBUTING.md entry that runs "conda env create --yes
-n cuml-clang-tidy -f conda/environments/clang_tidy_cuda-133_arch-$(uname
-m).yaml" to be explicit about x86_64-only support: replace or annotate that
command to target the x86_64 YAML (e.g., use arch=x86_64 instead of $(uname -m))
and add the suggested follow-up note telling users the conda clang-tidy
environment is provided for x86_64 only and to use the Docker-based clang-tidy
workflow on other architectures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0f8f56be-9c2c-4f99-b2e1-5dc9892275fa
📒 Files selected for processing (14)
.devcontainer/cuda13.3-conda/devcontainer.json.devcontainer/cuda13.3-pip/devcontainer.json.github/workflows/build.yaml.github/workflows/pr.yaml.github/workflows/pr_issue_status_automation.yml.github/workflows/test.yaml.github/workflows/trigger-breaking-change-alert.yamlBUILD.mdCONTRIBUTING.mdconda/environments/all_cuda-133_arch-aarch64.yamlconda/environments/all_cuda-133_arch-x86_64.yamlconda/environments/clang_tidy_cuda-133_arch-x86_64.yamlconda/environments/cpp_all_cuda-133_arch-x86_64.yamldependencies.yaml
| 2. Create and activate the needed conda environment: | ||
| ```bash | ||
| conda env create --yes -n cuml-clang-tidy -f conda/environments/clang_tidy_cuda-132_arch-$(uname -m).yaml | ||
| conda env create --yes -n cuml-clang-tidy -f conda/environments/clang_tidy_cuda-133_arch-$(uname -m).yaml |
There was a problem hiding this comment.
Make the clang-tidy env command explicit about x86_64 support.
This command uses $(uname -m), but the CUDA 13.3 clang-tidy env in this PR is x86_64-only. On aarch64 hosts, this resolves to a non-existent file and fails setup.
Suggested doc fix
- conda env create --yes -n cuml-clang-tidy -f conda/environments/clang_tidy_cuda-133_arch-$(uname -m).yaml
+ conda env create --yes -n cuml-clang-tidy -f conda/environments/clang_tidy_cuda-133_arch-x86_64.yaml# Optional follow-up note near this command:
# "The conda clang-tidy environment is currently provided for x86_64. On other
# architectures, use the Docker-based clang-tidy workflow above."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CONTRIBUTING.md` at line 147, Update the CONTRIBUTING.md entry that runs
"conda env create --yes -n cuml-clang-tidy -f
conda/environments/clang_tidy_cuda-133_arch-$(uname -m).yaml" to be explicit
about x86_64-only support: replace or annotate that command to target the x86_64
YAML (e.g., use arch=x86_64 instead of $(uname -m)) and add the suggested
follow-up note telling users the conda clang-tidy environment is provided for
x86_64 only and to use the Docker-based clang-tidy workflow on other
architectures.
|
/merge |
|
This looks relevant: NVIDIA/raft#2945 And looks like Dante fixed it for this repo in #8251 I'll merge in |
Contributes to rapidsai/build-planning#286
Notes for Reviewers
This switches GitHub Actions workflows to the
cuda-13.3.0branch from here: rapidsai/shared-workflows#574A future round of PRs will revert that back to
main, once all of RAPIDS is migrated.