Fix clang-tidy failures in CUDA 13.2 CI - #8251
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test b0f0a85 |
Contributor
Author
|
/ok to test fff675a |
divyegala
approved these changes
Jun 10, 2026
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates clang-tidy configuration and the clang-tidy runner script for improved compiler flag compatibility. The ChangesClang-tidy configuration and compiler flag handling
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cpp/scripts/run-clang-tidy.py`:
- Around line 184-186: The current loop using UNSUPPORTED_CLANG_FLAGS and
remove_item(command, flag) only removes exact tokens and can leave wrapper
tokens (e.g., "-Xcompiler") or inline forms ("-Xcompiler=-fno-merge-constants")
orphaned; update the filtering to remove (a) exact matches of each unsupported
flag, (b) tokens of the form "<wrapper>=<flag>" (check startswith for wrappers
like "-Xcompiler="), and (c) wrapper tokens that are separate arguments followed
by the flag (e.g., remove the "-Xcompiler" token when the next token equals the
unsupported flag). Implement this logic around the existing
UNSUPPORTED_CLANG_FLAGS and remove_item usage so command ends up free of both
standalone and wrapped forms of unsupported flags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c9f0af32-a0fc-4346-b566-5b15fc19e021
📒 Files selected for processing (2)
cpp/.clang-tidycpp/scripts/run-clang-tidy.py
💤 Files with no reviewable changes (1)
- cpp/.clang-tidy
Comment on lines
+184
to
+186
| for flag in UNSUPPORTED_CLANG_FLAGS: | ||
| while remove_item(command, flag) >= 0: | ||
| pass |
There was a problem hiding this comment.
Flag filtering can leave malformed compiler args.
At Line 185, removing only -fno-merge-constants by exact token can leave wrapper args like -Xcompiler orphaned (or miss inline forms like -Xcompiler=-fno-merge-constants), which can still break clang-tidy invocation.
Proposed fix
- for flag in UNSUPPORTED_CLANG_FLAGS:
- while remove_item(command, flag) >= 0:
- pass
+ i = 0
+ while i < len(command):
+ token = command[i]
+ removed = False
+ for flag in UNSUPPORTED_CLANG_FLAGS:
+ # direct token: ... -fno-merge-constants ...
+ if token == flag:
+ del command[i]
+ removed = True
+ break
+ # wrapped single token: ... -Xcompiler=-fno-merge-constants ...
+ if token == f"-Xcompiler={flag}":
+ del command[i]
+ removed = True
+ break
+ # wrapped pair: ... -Xcompiler -fno-merge-constants ...
+ if (
+ token == "-Xcompiler"
+ and i + 1 < len(command)
+ and command[i + 1] == flag
+ ):
+ del command[i : i + 2]
+ removed = True
+ break
+ if not removed:
+ i += 1🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cpp/scripts/run-clang-tidy.py` around lines 184 - 186, The current loop using
UNSUPPORTED_CLANG_FLAGS and remove_item(command, flag) only removes exact tokens
and can leave wrapper tokens (e.g., "-Xcompiler") or inline forms
("-Xcompiler=-fno-merge-constants") orphaned; update the filtering to remove (a)
exact matches of each unsupported flag, (b) tokens of the form
"<wrapper>=<flag>" (check startswith for wrappers like "-Xcompiler="), and (c)
wrapper tokens that are separate arguments followed by the flag (e.g., remove
the "-Xcompiler" token when the next token equals the unsupported flag).
Implement this logic around the existing UNSUPPORTED_CLANG_FLAGS and remove_item
usage so command ends up free of both standalone and wrapped forms of
unsupported flags.
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the clang-tidy PR job by:
AnalyzeTemporaryDtorskey from.clang-tidy, which clang-tidy 20 rejects.-fno-merge-constantsflag before invoking clang-tidy, since CUDA 13.2 toolchain commands can include it and clang treats it as an error underWarningsAsErrors.