build wheels with CUDA 13.0.x, test wheels against mix of CTK versions#7907
build wheels with CUDA 13.0.x, test wheels against mix of CTK versions#7907rapids-bot[bot] merged 10 commits intorapidsai:release/26.04from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughReplace local constraint files with an environment-provided Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ci/test_wheel_integrations.sh`:
- Line 33: The BERTopic install call using the command "rapids-pip-retry install
--prefer-binary bertopic" omits the pip constraint that other wheel tests use;
either append the constraint flag (--constraint "${PIP_CONSTRAINT}") to that
install invocation so it uses the same generated constraints, or add a short
inline comment above the "rapids-pip-retry install --prefer-binary bertopic"
line explaining why constraints are intentionally excluded for this integration
test (and reference that PIP_CONSTRAINT is set by rapids-init-pip) so the
deviation is explicit and auditable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ddae4d85-e5cf-4f8a-a961-c0b0f6a7c7d2
📒 Files selected for processing (6)
ci/test_wheel.shci/test_wheel_dask.shci/test_wheel_integrations.shdependencies.yamlpython/cuml/pyproject.tomlpython/libcuml/pyproject.toml
dependencies.yaml
Outdated
| packages: | ||
| # if no matching matrix selectors passed, list the unsuffixed packages | ||
| - &cuda_toolkit_any_cu13 cuda-toolkit[cublas,cufft,curand,cusolver,cusparse]==13.* | ||
| - nvidia-nvjitlink>=13.0,<14 |
There was a problem hiding this comment.
The solver does not find an issue with this vs the tight pinning in the cudatoolkit metapackage?
There was a problem hiding this comment.
Right, if the environment doesn't have requirement cuda-toolkit[nvjitlink] anywhere, then cuda-toolkit's == pin on nvidia-nvjitlink doesn't matter.
If someone were to pin cuda-toolkit[nvjitlink]=={specific-version} that's also find, as long as {specific-version}>=13.0 (taking advantage of the fact the nvJitLink major.minor happens to follow the CTK's major.minor).
|
/merge |
c181a14
into
rapidsai:release/26.04
Contributes to rapidsai/build-planning#257
nvidia-nvjitlink>={whatever-minor-version-they-were-built-against}Contributes to rapidsai/build-planning#256
Notes for Reviewers
Doesn't this need conda changes too?
I don't think so.
cuML doesn't directly use libnvjitlink in conda packages, and it dynamically links to libcuvs:
cuml/cpp/CMakeLists.txt
Line 64 in 95b7be3
https://github.com/rapidsai/cuml/blob/main/conda/recipes/libcuml/recipe.yaml#L118-L126
Wheels need a runtime dependency on
nvidia-nvjitlinkbecause they statically link cuVS:cuml/python/libcuml/CMakeLists.txt
Line 54 in 95b7be3