Test cuml.accel upstream test suite with sklearn 1.9 - #8207
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
df6621d to
2ad4377
Compare
2ad4377 to
ab92cde
Compare
This comment has been minimized.
This comment has been minimized.
ab92cde to
2f2213b
Compare
This comment has been minimized.
This comment has been minimized.
|
Codex-generated triage of the newly added xfail groups: P0: must fix P1: should fix
P2: nice-to-have
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdated scikit-learn test matrix pins from 1.8.0/1.7.2 to 1.9.0/1.8.0 and reorganized xfail test exclusion rules across multiple version ranges to accommodate compatibility differences in coordinate descent, ensemble voting, linear models, and numeric precision handling between scikit-learn versions. Changesscikit-learn 1.8 and 1.9 compatibility
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
Updates the
cuml.accelupstream scikit-learn test target matrix to coverscikit-learn1.9.0, and updates the xfail list for test IDs and behavior changes across the supported1.6,1.8, and1.9targets.Summary
1.8.0to1.9.0.1.7.2to1.8.0.1.6.0.scikit-learn>=1.9xfail groups for renamed tests and behavior differences observed in the updated upstream test suite.