Skip to content

Xfail failing wikipedia sklearn example - #8277

Closed
csadorf wants to merge 2 commits into
NVIDIA:mainfrom
csadorf:fix/wikipedia-principal-eigenvector-xfail
Closed

Xfail failing wikipedia sklearn example#8277
csadorf wants to merge 2 commits into
NVIDIA:mainfrom
csadorf:fix/wikipedia-principal-eigenvector-xfail

Conversation

@csadorf

@csadorf csadorf commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Adds an xfail for the upstream scikit-learn wikipedia_principal_eigenvector example, which currently fails without cuml.accel on the latest dependency stack with a SciPy sparse-array operation error.

Closes #8276

@csadorf
csadorf requested a review from a team as a code owner June 22, 2026 18:11
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 22, 2026
@csadorf
csadorf requested a review from jcrist June 22, 2026 18:11
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 22, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a86d1869-9899-414a-91fa-f7fa7187dba4

📥 Commits

Reviewing files that changed from the base of the PR and between 06e73fc and 4e1dc80.

📒 Files selected for processing (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated test configuration to mark expected failures for a specific upstream example based on dependency stack and whether GPU acceleration is enabled.

Walkthrough

Adds a single xfail entry to the scikit-learn upstream examples configuration file, marking applications::wikipedia_principal_eigenvector as expected to fail on scikit-learn>=1.9 without cuml.accel enabled, due to a NotImplementedError in scipy sparse array arithmetic.

Changes

xfail configuration update

Layer / File(s) Summary
xfail rule for wikipedia_principal_eigenvector
python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-examples.yaml
Adds an xfail entry for applications::wikipedia_principal_eigenvector conditioned on scikit-learn>=1.9 with a reason noting the scipy sparse array incompatibility when cuml.accel is absent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/cuml#7960: Both PRs modify the same xfail-examples.yaml file by adding expected-failure rules for specific scikit-learn example test IDs under certain dependency conditions.
  • rapidsai/cuml#8193: Both PRs add new xfail entries to xfail-examples.yaml for sklearn examples under unmet dependency scenarios.
  • rapidsai/cuml#8207: Both PRs update scikit-learn 1.9 upstream test xfail configuration for cuml.accel—this PR adds a rule for wikipedia_principal_eigenvector in xfail-examples.yaml while that PR broadly updates related xfail configurations.

Suggested reviewers

  • viclafargue
  • dantegd
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title concisely describes the main change: adding an xfail marker for the failing wikipedia sklearn example.
Description check ✅ Passed The description clearly explains the change and links to the related issue (#8276) documenting the scipy sparse-array operation error.
Linked Issues check ✅ Passed The PR fully addresses issue #8276 by adding the xfail marker for the wikipedia_principal_eigenvector example on scikit-learn>=1.9, matching the requirement to resolve CI failures.
Out of Scope Changes check ✅ Passed The change is limited to adding a single xfail rule in the xfail-examples.yaml file, directly addressing the failing test documented in issue #8276 with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf

csadorf commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 06e73fc

@csadorf

csadorf commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4e1dc80

@jcrist jcrist mentioned this pull request Jun 22, 2026
rapids-bot Bot pushed a commit that referenced this pull request Jun 22, 2026
We have some ongoing CI failures that showed up last week. This fixes them.

- Relaxes tolerance on a `cuml.explainer` xgboost test, this changed due to recent xgboost release.
- Moves xfail marks for a bunch of tests due to sklearn's repr erroring on our CI machines to `strict: false`. These appear to be failing due to a misconfigured codec on one or more of our machines. Since they don't fail everywhere, they should be `strict: false` for now.
- Marks `test_logreg_l1[42-csr_matrix]` as flaky on sklearn 1.9.
- Also cherry-picks the fix for the examples from #8277 (per offline request by Simon), since that's also needed to fix our nightlies.

Fixes #8265.
Fixes #8278.
Fixes #8279.
Fixes #8276.

Authors:
  - Jim Crist-Harif (https://github.com/jcrist)
  - Simon Adorf (https://github.com/csadorf)

Approvers:
  - Simon Adorf (https://github.com/csadorf)

URL: #8280
@csadorf

csadorf commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Merged with #8280 .

@csadorf csadorf closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] sklearn examples job fails in wikipedia_principal_eigenvector

3 participants