Xfail failing wikipedia sklearn example - #8277
Closed
csadorf wants to merge 2 commits into
Closed
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a single Changesxfail configuration update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
/ok to test 06e73fc |
csadorf
commented
Jun 22, 2026
Contributor
Author
|
/ok to test 4e1dc80 |
Merged
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jun 22, 2026
We have some ongoing CI failures that showed up last week. This fixes them. - Relaxes tolerance on a `cuml.explainer` xgboost test, this changed due to recent xgboost release. - Moves xfail marks for a bunch of tests due to sklearn's repr erroring on our CI machines to `strict: false`. These appear to be failing due to a misconfigured codec on one or more of our machines. Since they don't fail everywhere, they should be `strict: false` for now. - Marks `test_logreg_l1[42-csr_matrix]` as flaky on sklearn 1.9. - Also cherry-picks the fix for the examples from #8277 (per offline request by Simon), since that's also needed to fix our nightlies. Fixes #8265. Fixes #8278. Fixes #8279. Fixes #8276. Authors: - Jim Crist-Harif (https://github.com/jcrist) - Simon Adorf (https://github.com/csadorf) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #8280
Contributor
Author
|
Merged with #8280 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an xfail for the upstream scikit-learn
wikipedia_principal_eigenvectorexample, which currently fails withoutcuml.accelon the latest dependency stack with a SciPy sparse-array operation error.Closes #8276