Skip to content

Mark test_logreg_l1[42-csr_array] flaky - #8289

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jcrist:mark-logreg-test-flaky
Jun 24, 2026
Merged

Mark test_logreg_l1[42-csr_array] flaky#8289
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
jcrist:mark-logreg-test-flaky

Conversation

@jcrist

@jcrist jcrist commented Jun 24, 2026

Copy link
Copy Markdown
Member

Fixes #8265

@jcrist
jcrist requested a review from a team as a code owner June 24, 2026 17:10
@jcrist
jcrist requested a review from betatim June 24, 2026 17:10
@jcrist jcrist self-assigned this Jun 24, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 24, 2026
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Cython / Python Cython or Python issue and removed Cython / Python Cython or Python issue labels Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f6cccf51-7d44-485e-9974-72aa293c9590

📥 Commits

Reviewing files that changed from the base of the PR and between 267309c and 01ed938.

📒 Files selected for processing (1)
  • python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-list.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Added an additional flaky test exception for a logistic regression case under newer scikit-learn versions, expanding coverage of an existing test group.

Walkthrough

Adds a single flaky xfail entry for test_logreg_l1[42-csr_array] to the scikit-learn accelerator xfail list under the scikit-learn>=1.9 condition, alongside the already-listed csr_matrix variant.

Changes

Flaky xfail list update

Layer / File(s) Summary
Add csr_array flaky xfail entry
python/cuml/cuml_accel_tests/upstream/scikit-learn/xfail-list.yaml
Adds test_logreg_l1[42-csr_array] to the cuml_accel_flaky (strict: false) block for scikit-learn>=1.9, mirroring the existing csr_matrix variant.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • rapidsai/cuml#8207: Modifies the same xfail YAML file for scikit-learn>=1.9 LogisticRegression L1/callback-related cases, directly related xfail tuning work.
  • rapidsai/cuml#8280: Adds/updates the cuml_accel_flaky xfail entry for test_logreg_l1[42-csr_matrix] under scikit-learn>=1.9 in the same file.

Suggested labels

improvement, non-breaking

Suggested reviewers

  • csadorf
  • viclafargue
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the flaky test entry being added.
Description check ✅ Passed The description is related to the change and references the linked issue.
Linked Issues check ✅ Passed The change stays within the flaky logistic-regression test family and matches the issue's intent to treat unstable CI behavior as flaky.
Out of Scope Changes check ✅ Passed The PR only updates the scikit-learn xfail list, with no apparent unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jinsolp jinsolp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jim!

@jcrist

jcrist commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 63a3b61 into NVIDIA:main Jun 24, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Flaky nightly conda-python-scikit-learn-accel-tests failure: test_logistic.py::test_logreg_l1[42-csr_matrix]

5 participants