Forward merge release/26.04 into main - #7936
Conversation
## Summary The PR/issue project automation workflow set `OVERRIDE_ITEM: true` for PRs targeting `release/*`, so every `synchronize` run re-applied the Release field from the base branch name and overwrote manual values (e.g. after retargeting). ## Changes - Set `OVERRIDE_ITEM: false` on `update-release` for all cases that run that job (no conditional). - Drop the `override-item` job output and the `echo "override-item=…"` lines from the determine-version step. Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - James Lamb (https://github.com/jameslamb) URL: NVIDIA#7921
- Bump sklearn versions we test with. - Remove no longer relevant non-numeric limitation. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Tim Head (https://github.com/betatim) URL: NVIDIA#7929
…VIDIA#7807) Closes NVIDIA#7806 When there are more workers than data partitions, some workers end up with no data, causing hangs or crashes in collective operations that expect all participants to contribute rows. The changes in this PR prune workers with zero-row partitions from `DistributedDataHandler` before initializing `NCCL` communicators. Authors: - Victor Lafargue (https://github.com/viclafargue) - Jim Crist-Harif (https://github.com/jcrist) Approvers: - James Lamb (https://github.com/jameslamb) - Jim Crist-Harif (https://github.com/jcrist) URL: NVIDIA#7807
We're seeing some test failures with the new openblas release on aarch64 (accuracy issues on comparison with sklearn's results, _not_ issues in cuml's execution). I suspect a regression in openblas. For now we pin openblas on aarch64. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - James Lamb (https://github.com/jameslamb) URL: NVIDIA#7933
bdice
left a comment
There was a problem hiding this comment.
Make sure to /merge nosquash when merging this.
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR refactors distributed data handling in Dask workflows to cache per-worker partition row counts and gracefully handle empty partitions. It also updates CI automation, adds OpenBLAS version constraints to conda environments, updates scikit-learn compatibility documentation, and adds comprehensive tests for empty worker scenarios. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@python/cuml/cuml/dask/common/input_utils.py`:
- Around line 145-151: The warnings.warn call in input_utils.py (inside the code
path that logs empty_workers) lacks a stacklevel, causing Ruff B028 and pointing
the warning at the utility instead of the caller; update the warnings.warn
invocation (the one that constructs the message about empty_workers) to include
an explicit stacklevel parameter (e.g., stacklevel=2 or higher) so the warning
originates from the caller location.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 32cac1f0-f724-4434-8bfe-d1da7a44a502
📒 Files selected for processing (8)
.github/workflows/pr_issue_status_automation.ymlconda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-131_arch-aarch64.yamldependencies.yamldocs/source/cuml-accel/limitations.rstpython/cuml/cuml/dask/common/input_utils.pypython/cuml/cuml/dask/neighbors/nearest_neighbors.pypython/cuml/tests/dask/test_dask_base.py
💤 Files with no reviewable changes (1)
- python/cuml/cuml/dask/neighbors/nearest_neighbors.py
|
/merge nosquash |
|
Commit history integrity check failed: not all commits from original PR #7923 appear to be present individually in this PR's history. This usually happens if commits were squashed during the manual resolution process. Please ensure all original commits are preserved individually. You can fix this and try the |
No description provided.