Skip to content

ci: preserve Release project field also on release/* PRs - #7921

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.04from
csadorf:pr-automation-release-field-no-override
Mar 23, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.04from
csadorf:pr-automation-release-field-no-override

Conversation

@csadorf

@csadorf csadorf commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Summary

The PR/issue project automation workflow set OVERRIDE_ITEM: true for PRs targeting release/*, so every synchronize run re-applied the Release field from the base branch name and overwrote manual values (e.g. after retargeting).

Changes

  • Set OVERRIDE_ITEM: false on update-release for all cases that run that job (no conditional).
  • Drop the override-item job output and the echo "override-item=…" lines from the determine-version step.

@csadorf
csadorf requested a review from a team as a code owner March 20, 2026 21:53
@csadorf
csadorf requested a review from msarahan March 20, 2026 21:53
@coderabbitai

coderabbitai Bot commented Mar 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 961c2831-c564-4146-8884-f05fb883c116

📥 Commits

Reviewing files that changed from the base of the PR and between eb56525 and 2a8cd1b.

📒 Files selected for processing (1)
  • .github/workflows/pr_issue_status_automation.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated release automation configuration to standardize override behavior for release field updates, ensuring consistent handling across deployment branches.

Walkthrough

Removed the override-item output from the get-release-version job and the branch-conditional logic that emitted it. The update-release job now hardcodes OVERRIDE_ITEM to false instead of deriving it dynamically from the base branch context.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/pr_issue_status_automation.yml
Removed override-item output declaration from get-release-version job; removed conditional logic in determine-version step that emitted override-item=true for release/* and override-item=false for main; hardcoded OVERRIDE_ITEM: false in update-release job instead of consuming the dynamic output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly summarizes the main change: preventing the Release project field from being overwritten on release/* branch PRs, which is the core objective of the changeset.
Description check ✅ Passed The description is related to the changeset, explaining the problem being fixed and detailing the specific changes made to the workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 20, 2026
@csadorf

csadorf commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 2076715 into NVIDIA:release/26.04 Mar 23, 2026
58 checks passed
@csadorf
csadorf deleted the pr-automation-release-field-no-override branch March 23, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants