fix(devcontainers): build with Python 3.13 while dependencies are unavailable - #7916
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
| "nofile=500000" | ||
| ], | ||
| "hostRequirements": {"gpu": "optional"}, | ||
| // TODO: remove the PYTHON_VERSION override when all of cuml's dependencies have Python 3.14 support |
There was a problem hiding this comment.
JavaScript comments technically aren't valid in JSON files but sometimes parsers are relaxed and won't complain...
There was a problem hiding this comment.
Who needs comments? (Everyone).
I had forgotten this -- hopefully devcontainer parsing is more relaxed
There was a problem hiding this comment.
This actually did come back to bite me. :( I do some parsing of the devcontainer files with jq and this broke it. I'm working around it with a sed command to remove comments in my tooling... but we should probably remove it.
|
/merge |
…vailable (NVIDIA#7916) We bumped the default devcontainer Python version to 3.14 in rapidsai/devcontainers#677 but some repos (like `cuml`) have optional dependencies without Python 3.14 support. We need to override the Python version temporarily until those deps catch up. I'll also open a tracking issue so we remember to undo this. Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Bradley Dice (https://github.com/bdice) URL: NVIDIA#7916
cuml has optional dependencies without Python 3.14 support. Pin PYTHON_VERSION=3.13 for the 'rmm ucxx raft cuvs cuml' RAPIDS CI job until those dependencies catch up. See NVIDIA/cuml#7916 for context.
cuml has optional dependencies without Python 3.14 support. Pin PYTHON_VERSION=3.13 for the 'rmm ucxx raft cuvs cuml' RAPIDS CI job until those dependencies catch up. See NVIDIA/cuml#7916 for context.
* Pin Python 3.13 for RAPIDS cuml CI job cuml has optional dependencies without Python 3.14 support. Pin PYTHON_VERSION=3.13 for the 'rmm ucxx raft cuvs cuml' RAPIDS CI job until those dependencies catch up. See NVIDIA/cuml#7916 for context. * Fix rapids-build-utils pinning
Followup to #7916 to remove the commend. Technically not valid javascript -- while github and devcontainers don't seem to mind, it does break other tooling that relies on `jq` being able to parse the devcontainer config files Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Jim Crist-Harif (https://github.com/jcrist) - James Lamb (https://github.com/jameslamb) URL: #7952
* Pin Python 3.13 for RAPIDS cuml CI job cuml has optional dependencies without Python 3.14 support. Pin PYTHON_VERSION=3.13 for the 'rmm ucxx raft cuvs cuml' RAPIDS CI job until those dependencies catch up. See NVIDIA/cuml#7916 for context. * Fix rapids-build-utils pinning
* Pin Python 3.13 for RAPIDS cuml CI job cuml has optional dependencies without Python 3.14 support. Pin PYTHON_VERSION=3.13 for the 'rmm ucxx raft cuvs cuml' RAPIDS CI job until those dependencies catch up. See NVIDIA/cuml#7916 for context. * Fix rapids-build-utils pinning
We bumped the default devcontainer Python version to 3.14 in rapidsai/devcontainers#677 but some repos (like
cuml) have optional dependencies without Python 3.14 support.We need to override the Python version temporarily until those deps catch up.
I'll also open a tracking issue so we remember to undo this.