Skip to content

chore: remove comment in devcontainer.json that breaks jq - #7952

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
gforsyth:remove_devcontainer_comments
Apr 7, 2026
Merged

chore: remove comment in devcontainer.json that breaks jq#7952
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
gforsyth:remove_devcontainer_comments

Conversation

@gforsyth

@gforsyth gforsyth commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Followup to #7916 to remove the commend. Technically not valid javascript -- while github and devcontainers don't seem to mind, it does break other tooling that relies on jq being able to parse the devcontainer config files

@gforsyth
gforsyth requested a review from a team as a code owner April 6, 2026 17:40
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 6, 2026
@gforsyth
gforsyth requested a review from jameslamb April 6, 2026 17:40
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 6, 2026
@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1fcdfd58-050c-4025-a873-7c47ca6c7d81

📥 Commits

Reviewing files that changed from the base of the PR and between df22c7c and 5142dc3.

📒 Files selected for processing (4)
  • .devcontainer/cuda12.9-conda/devcontainer.json
  • .devcontainer/cuda12.9-pip/devcontainer.json
  • .devcontainer/cuda13.1-conda/devcontainer.json
  • .devcontainer/cuda13.1-pip/devcontainer.json
💤 Files with no reviewable changes (4)
  • .devcontainer/cuda13.1-pip/devcontainer.json
  • .devcontainer/cuda13.1-conda/devcontainer.json
  • .devcontainer/cuda12.9-conda/devcontainer.json
  • .devcontainer/cuda12.9-pip/devcontainer.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed outdated TODO comments from multiple development container configuration files. Updates cover different CUDA versions and various package management approaches. This routine maintenance has zero functional impact—all configuration settings, environment variables, container features, and runtime behavior remain completely unchanged and fully operational.

Walkthrough

Removed TODO comments from four devcontainer configuration files across different CUDA versions. The comments referenced overriding PYTHON_VERSION to 3.13 pending Python 3.14 support in cuML dependencies. No functional configuration changes were made.

Changes

Cohort / File(s) Summary
Devcontainer TODO comment cleanup
.devcontainer/cuda12.9-conda/devcontainer.json, .devcontainer/cuda12.9-pip/devcontainer.json, .devcontainer/cuda13.1-conda/devcontainer.json, .devcontainer/cuda13.1-pip/devcontainer.json
Removed single-line TODO comments referencing PYTHON_VERSION override. All container environment variables and feature settings remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • AyodeAwe
  • bdice
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing comments from devcontainer.json files that break jq parsing, which aligns with the actual modifications across all four devcontainer configuration files.
Description check ✅ Passed The description clearly explains the purpose of the changes: removing comments that break jq tooling, and references the related issue #7916, providing relevant context about the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jcrist jcrist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jameslamb

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 14267cf into NVIDIA:main Apr 7, 2026
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants