Skip to content

fix(devcontainers): build with Python 3.13 while dependencies are unavailable #7916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Mar 19, 2026
Merged

fix(devcontainers): build with Python 3.13 while dependencies are unavailable #7916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .devcontainer/cuda12.9-conda/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
"nofile=500000"
],
"hostRequirements": {"gpu": "optional"},
// TODO: remove the PYTHON_VERSION override when all of cuml's dependencies have Python 3.14 support

@bdice bdice Mar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript comments technically aren't valid in JSON files but sometimes parsers are relaxed and won't complain...

@gforsyth gforsyth Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who needs comments? (Everyone).

I had forgotten this -- hopefully devcontainer parsing is more relaxed

@bdice bdice Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually did come back to bite me. :( I do some parsing of the devcontainer files with jq and this broke it. I'm working around it with a sed command to remove comments in my tooling... but we should probably remove it.

"containerEnv": {"PYTHON_VERSION": "3.13"},
"features": {
"ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:26.4": {}
},
Expand Down
2 changes: 2 additions & 0 deletions .devcontainer/cuda12.9-pip/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
"nofile=500000"
],
"hostRequirements": {"gpu": "optional"},
// TODO: remove the PYTHON_VERSION override when all of cuml's dependencies have Python 3.14 support
"containerEnv": {"PYTHON_VERSION": "3.13"},
"features": {
"ghcr.io/rapidsai/devcontainers/features/cuda:26.4": {
"version": "12.9",
Expand Down
2 changes: 2 additions & 0 deletions .devcontainer/cuda13.1-conda/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
"nofile=500000"
],
"hostRequirements": {"gpu": "optional"},
// TODO: remove the PYTHON_VERSION override when all of cuml's dependencies have Python 3.14 support
"containerEnv": {"PYTHON_VERSION": "3.13"},
"features": {
"ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:26.4": {}
},
Expand Down
2 changes: 2 additions & 0 deletions .devcontainer/cuda13.1-pip/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
"nofile=500000"
],
"hostRequirements": {"gpu": "optional"},
// TODO: remove the PYTHON_VERSION override when all of cuml's dependencies have Python 3.14 support
"containerEnv": {"PYTHON_VERSION": "3.13"},
"features": {
"ghcr.io/rapidsai/devcontainers/features/cuda:26.4": {
"version": "13.1",
Expand Down
Loading