Skip to content

[DO NOT MERGE] temporarily bump build stack to 9.3.0 for testing - #3379

Closed
kkraus14 wants to merge 3 commits into
NVIDIA:branch-0.18from
kkraus14:build_stack_9_3_0
Closed

[DO NOT MERGE] temporarily bump build stack to 9.3.0 for testing#3379
kkraus14 wants to merge 3 commits into
NVIDIA:branch-0.18from
kkraus14:build_stack_9_3_0

Conversation

@kkraus14

@kkraus14 kkraus14 commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

DO NOT MERGE

Testing for rapidsai/integration#202

@kkraus14 kkraus14 added gpuCI gpuCI issue conda conda issue DO NOT MERGE Hold off on merging; see PR for details labels Jan 15, 2021
@kkraus14
kkraus14 requested a review from a team as a code owner January 15, 2021 07:23
@github-actions github-actions Bot added the Ops label Jan 15, 2021
@dantegd dantegd mentioned this pull request Jan 19, 2021
Closed
This was referenced Jan 19, 2021
Closed
Merged
rapids-bot Bot pushed a commit that referenced this pull request Jan 20, 2021
@JohnZed
XFail Holt Winters test where statsmodels has known issues with gcc 9…
816bb65 
….3.0(#3385)

In PR #3379, we observed this error in statsmodels (obtaining nans) that is unrelated to cuml but occurs with gcc 9.3.0. (See issue #3384.) For now, we will xfail.

Authors:
  - John Zedlewski <jzedlewski@nvidia.com>

Approvers:
  - Dante Gama Dessavre (@dantegd)

URL: #3385
@kkraus14

kkraus14 commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

1 similar comment
@kkraus14

kkraus14 commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

@codecov-io

codecov-io commented Jan 21, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3379 (af63837) into branch-0.18 (550121b) will increase coverage by 0.14%.
The diff coverage is 85.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3379      +/-   ##
===============================================
+ Coverage        71.48%   71.63%   +0.14%     
===============================================
  Files              207      210       +3     
  Lines            16748    16924     +176     
===============================================
+ Hits             11973    12123     +150     
- Misses            4775     4801      +26
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/fil/fil.pyx 91.87% <60.00%> (-1.88%) ⬇️
python/cuml/ensemble/randomforestclassifier.pyx 73.72% <66.66%> (ø)
python/cuml/multiclass/multiclass.py 84.21% <84.21%> (ø)
python/cuml/model_selection/_split.py 90.35% <90.35%> (ø)
python/cuml/svm/svm_base.pyx 94.27% <91.30%> (-0.63%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd508c...af63837. Read the comment docs.

@JohnZed

JohnZed commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

rerun tests

@mike-wendt

mike-wendt commented Jan 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@kkraus14 @JohnZed looks like we need an updated faiss for this to work as the version of liblapack installed with gcc/g++ 9.3 is not compatible with this (FWIW liblapack 3.9 gets installed):

from https://anaconda.org/rapidsai-nightly/faiss/files

_openmp_mutex >=4.5, cudatoolkit 11.0|11.0.*, libblas >=3.8.0,<4.0a0, libfaiss 1.6.3 *_cuda, 
libgcc-ng >=7.5.0, liblapack >=3.8.0,<3.9.0a0, libstdcxx-ng >=7.5.0, numpy >=1.14.6,<2.0a0, 
python_abi 3.8.* *_cp38

what is the version we need? can this be done in conda-forge?

kkraus14
kkraus14 commented Jan 26, 2021
View reviewed changes
Comment thread ci/gpu/build.sh
gpuci_conda_retry remove --force rapids-build-env rapids-notebook-env
gpuci_conda_retry remove --force rapids-build-env rapids-notebook-env faiss
gpuci_conda_retry install "libgcc-ng=9.3.0" "libstdcxx-ng=9.3.0" "libgfortran-ng=9.3.0"
gpuci_conda_retry install "conda-forge::faiss=1.6.3" "conda-forge::faiss-proc=*=cuda"

@kkraus14 kkraus14 Jan 26, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's 1.6.5 on conda-forge as well, any reason we can't upgrade?

@dantegd dantegd Jan 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not entirely sure, at some point there was some file re-organization and we would need some minor adjustments

@mike-wendt mike-wendt Jan 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also remove our version of faiss if we can verify that conda-forge has a version for CUDA 11.0

@jakirkham jakirkham Jan 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was added in PR ( conda-forge/faiss-split-feedstock#13 ). Includes version 1.6.3

@dantegd dantegd Jan 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the best path after everything passes with the conda-forge package

@kkraus14 kkraus14 Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixed the issues 🎉

@dantegd

dantegd commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

rerun tests

@mike-wendt

mike-wendt commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

Closing now that rapidsai/integration#202 is merged

@mike-wendt mike-wendt closed this Feb 1, 2021
@codecov-commenter

codecov-commenter commented Jul 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.66%. Comparing base (b8e71ca) to head (75befe2).
Report is 14056 commits behind head on branch-0.18.

Additional details and impacted files 
@@               Coverage Diff               @@
##           branch-0.18    #3379      +/-   ##
===============================================
+ Coverage        71.47%   71.66%   +0.19%     
===============================================
  Files              207      210       +3     
  Lines            16753    16945     +192     
===============================================
+ Hits             11974    12144     +170     
- Misses            4779     4801      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dantegd dantegd dantegd left review comments
@jakirkham jakirkham jakirkham left review comments
+1 more reviewer
@mike-wendt mike-wendt mike-wendt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conda conda issue DO NOT MERGE Hold off on merging; see PR for details gpuCI gpuCI issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kkraus14 @codecov-io @JohnZed @mike-wendt @dantegd @codecov-commenter @jakirkham