Skip to content

XFail Holt Winters test where statsmodels has known issues with gcc 9.3.0 - #3385

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.18from
JohnZed:xfail-hw-for-93
Jan 20, 2021
Merged

XFail Holt Winters test where statsmodels has known issues with gcc 9.3.0#3385
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.18from
JohnZed:xfail-hw-for-93

Conversation

@JohnZed

@JohnZed JohnZed commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

In PR #3379, we observed this error in statsmodels (obtaining nans) that is unrelated to cuml but occurs with gcc 9.3.0. (See issue #3384.) For now, we will xfail.

@JohnZed JohnZed added bug Something isn't working non-breaking Non-breaking change labels Jan 19, 2021
@JohnZed
JohnZed requested a review from dantegd January 19, 2021 19:37
@JohnZed
JohnZed requested a review from a team as a code owner January 19, 2021 19:37
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jan 19, 2021

@dantegd dantegd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JohnZed

JohnZed commented Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

@codecov-io

codecov-io commented Jan 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3385 (3c998b6) into branch-0.18 (550121b) will increase coverage by 0.14%.
The diff coverage is 85.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #3385      +/-   ##
===============================================
+ Coverage        71.48%   71.63%   +0.14%     
===============================================
  Files              207      210       +3     
  Lines            16748    16924     +176     
===============================================
+ Hits             11973    12123     +150     
- Misses            4775     4801      +26     
Impacted Files Coverage Δ
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/dask/ensemble/base.py 19.69% <30.43%> (+0.36%) ⬆️
python/cuml/ensemble/randomforestregressor.pyx 70.83% <44.44%> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 30.00% <50.00%> (+0.51%) ⬆️
python/cuml/dask/ensemble/randomforestregressor.py 35.08% <50.00%> (+0.54%) ⬆️
python/cuml/fil/fil.pyx 91.87% <60.00%> (-1.88%) ⬇️
python/cuml/ensemble/randomforestclassifier.pyx 73.72% <66.66%> (ø)
python/cuml/multiclass/multiclass.py 84.21% <84.21%> (ø)
python/cuml/model_selection/_split.py 90.35% <90.35%> (ø)
python/cuml/svm/svm_base.pyx 94.27% <91.30%> (-0.63%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72c54a...3c998b6. Read the comment docs.

@JohnZed

JohnZed commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

@JohnZed

JohnZed commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

last time, only gpuCI/cuml/gpu/cuda/10.2/python/3.8/centos7 failed. Doing one more rerun to see if that is consistent.

@JohnZed

JohnZed commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

looks like it worked except we got differing versions of libcudf and cudf in one run (maybe packages were in the process of being uploaded!) so rerunning again

@JohnZed

JohnZed commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

@rapids-bot
rapids-bot Bot merged commit 816bb65 into NVIDIA:branch-0.18 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants