Skip to content

[DO NOT MERGE] temporarily bump build stack to 9.3.0 for testing #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkraus14 wants to merge 3 commits into from
Closed

[DO NOT MERGE] temporarily bump build stack to 9.3.0 for testing #3379

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af63837
temporarily bump build stack to 9.3.0 for testing
kkraus14 Jan 15, 2021
441a551
DBG Install conda-forge faiss explicitly for cuda 11
dantegd Jan 26, 2021
75befe2
FIX Copyright year
dantegd Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright (c) 2018-2020, NVIDIA CORPORATION.
# Copyright (c) 2018-2021, NVIDIA CORPORATION.
##############################################
# cuML GPU build and test script for CI #
##############################################
Expand Down Expand Up @@ -61,6 +61,9 @@ gpuci_conda_retry install -c conda-forge -c rapidsai -c rapidsai-nightly -c nvid
# https://docs.rapids.ai/maintainers/depmgmt/
# gpuci_conda_retry remove --force rapids-build-env rapids-notebook-env
# gpuci_conda_retry install -y "your-pkg=1.0.0"
gpuci_conda_retry remove --force rapids-build-env rapids-notebook-env faiss
gpuci_conda_retry install "libgcc-ng=9.3.0" "libstdcxx-ng=9.3.0" "libgfortran-ng=9.3.0"
gpuci_conda_retry install "conda-forge::faiss=1.6.3" "conda-forge::faiss-proc=*=cuda"

@kkraus14 kkraus14 Jan 26, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's 1.6.5 on conda-forge as well, any reason we can't upgrade?

@dantegd dantegd Jan 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not entirely sure, at some point there was some file re-organization and we would need some minor adjustments

@mike-wendt mike-wendt Jan 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also remove our version of faiss if we can verify that conda-forge has a version for CUDA 11.0

@jakirkham jakirkham Jan 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was added in PR ( conda-forge/faiss-split-feedstock#13 ). Includes version 1.6.3

@dantegd dantegd Jan 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the best path after everything passes with the conda-forge package

@kkraus14 kkraus14 Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixed the issues 🎉


gpuci_logger "Install contextvars if needed"
py_ver=$(python -c "import sys; print('.'.join(map(str, sys.version_info[:2])))")
Expand Down Expand Up @@ -110,7 +113,7 @@ if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then
################################################################################
# TEST - Run GoogleTest and py.tests for libcuml and cuML
################################################################################

if hasArg --skip-tests; then
gpuci_logger "Skipping Tests"
exit 0
Expand All @@ -124,7 +127,7 @@ if [[ -z "$PROJECT_FLASH" || "$PROJECT_FLASH" == "0" ]]; then
cd $WORKSPACE/cpp/build
GTEST_OUTPUT="xml:${WORKSPACE}/test-results/libcuml_cpp/" ./test/ml


gpuci_logger "Python pytest for cuml"
cd $WORKSPACE/python

Expand Down Expand Up @@ -165,7 +168,7 @@ else
#Project Flash
export LIBCUML_BUILD_DIR="$WORKSPACE/ci/artifacts/cuml/cpu/conda_work/cpp/build"
export LD_LIBRARY_PATH="$LIBCUML_BUILD_DIR:$LD_LIBRARY_PATH"

if hasArg --skip-tests; then
gpuci_logger "Skipping Tests"
exit 0
Expand All @@ -191,7 +194,7 @@ else
CONDA_FILE=${CONDA_FILE//-/=} #convert to conda install
gpuci_logger "Installing $CONDA_FILE"
conda install -c $WORKSPACE/ci/artifacts/cuml/cpu/conda-bld/ "$CONDA_FILE"

gpuci_logger "Building cuml"
"$WORKSPACE/build.sh" -v cuml --codecov

Expand All @@ -205,7 +208,7 @@ else
################################################################################
# TEST - Run notebook tests
################################################################################

gpuci_logger "Notebook tests"
set +e -Eo pipefail
EXITCODE=0
Expand Down