Skip to content

Use ptxcompiler to patch Numba at runtime to support CUDA enhanced compatibility. #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajschmidt8 merged 26 commits into from
Nov 29, 2021
Merged

Use ptxcompiler to patch Numba at runtime to support CUDA enhanced compatibility. #9687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e3ce7cb
Use ptxcompiler to patch Numba at runtime to support CUDA-enhanced co…
shwina Nov 15, 2021
7f5c4b9
del function that we don't want to expose
shwina Nov 16, 2021
c06cda2
Newlines
shwina Nov 16, 2021
3438bdd
Newlines
shwina Nov 16, 2021
61ff5f2
Don't use debug=True in numba kernels
shwina Nov 16, 2021
17287cb
Describe change
shwina Nov 16, 2021
97c6946
Improve description
shwina Nov 16, 2021
95963f5
Change numba version
shwina Nov 16, 2021
9c66ae3
Remove raise
shwina Nov 16, 2021
9aebb54
fix pytests for latest numpy
galipremsagar Nov 16, 2021
5415889
Merge remote-tracking branch 'ashwin/cec-ptxcompiler' into cec-ptxcom…
galipremsagar Nov 16, 2021
9eb1579
upgrade clang to 11.1.0
galipremsagar Nov 17, 2021
b192ab9
Update python/cudf/cudf/tests/test_extension_compilation.py
galipremsagar Nov 17, 2021
e63b0a9
Update python/cudf/cudf/__init__.py
shwina Nov 18, 2021
9af660b
Merge branch 'branch-21.12' into clang_11.1.0
galipremsagar Nov 18, 2021
74a6c79
Remove duplicated code
shwina Nov 18, 2021
3675c0c
Change numba pin
shwina Nov 18, 2021
6113dd7
Merge branch 'branch-21.12' of https://github.com/rapidsai/cudf into …
shwina Nov 18, 2021
6a8a8bb
Merge remote-tracking branch 'galipremsagar/clang_11.1.0' into cec-pt…
shwina Nov 18, 2021
2334d95
Merge remote-tracking branch 'upstream/branch-21.12' into cec-ptxcomp…
galipremsagar Nov 18, 2021
8455c60
Update conda/environments/cudf_dev_cuda11.5.yml
shwina Nov 22, 2021
f8019de
Update conda/environments/cudf_dev_cuda11.2.yml
shwina Nov 22, 2021
65da07d
Update conda/recipes/cudf/meta.yaml
shwina Nov 22, 2021
6279f6e
Merge branch 'cec-ptxcompiler' of github.com:shwina/cudf into cec-ptx…
shwina Nov 22, 2021
c741e1d
Merge branch 'cec-ptxcompiler' of github.com:shwina/cudf into cec-ptx…
shwina Nov 22, 2021
69dca77
One more linux64
shwina Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conda/environments/cudf_dev_cuda11.0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ dependencies:
- git+https://github.com/dask/distributed.git@main
- git+https://github.com/python-streamz/streamz.git@master
- pyorc
- ptxcompiler
Comment thread
shwina marked this conversation as resolved.
Resolved
1 change: 1 addition & 0 deletions conda/environments/cudf_dev_cuda11.2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ dependencies:
- git+https://github.com/dask/distributed.git@main
- git+https://github.com/python-streamz/streamz.git@master
- pyorc
- ptxcompiler
1 change: 1 addition & 0 deletions conda/environments/cudf_dev_cuda11.5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ dependencies:
- git+https://github.com/dask/distributed.git@main
- git+https://github.com/python-streamz/streamz.git@master
- pyorc
- ptxcompiler
2 changes: 1 addition & 1 deletion conda/recipes/cudf/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ requirements:
- nvtx >=0.2.1

@raydouglass raydouglass Nov 18, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to increase the numba pin in this file as well?

@shwina shwina Nov 18, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

- packaging
- cachetools

- ptxcompiler # CUDA enhanced compatibility. See https://github.com/rapidsai/ptxcompiler
Comment thread
shwina marked this conversation as resolved.
Resolved
Comment thread
shwina marked this conversation as resolved.
Resolved
test: # [linux64]
requires: # [linux64]
- cudatoolkit {{ cuda_version }}.* # [linux64]
Expand Down
7 changes: 7 additions & 0 deletions python/cudf/cudf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,16 @@
from cudf.core.tools.datetimes import date_range
from cudf.utils.dtypes import _NA_REP
from cudf.utils.utils import set_allocator
from ptxcompiler.patch import patch_numba_codegen_if_needed
Comment thread
shwina marked this conversation as resolved.
Resolved

cuda.set_memory_manager(rmm.RMMNumbaManager)
cupy.cuda.set_allocator(rmm.rmm_cupy_allocator)

# Patch Numba to support CUDA enhanced compatibility.
# See https://github.com/rapidsai/ptxcompiler for
# details.
patch_numba_codegen_if_needed()
Comment thread
shwina marked this conversation as resolved.
Resolved

try:
# Numba 0.54: Disable low occupancy warnings
numba_config.CUDA_LOW_OCCUPANCY_WARNINGS = 0
Expand All @@ -113,5 +119,6 @@
pass
del numba_config


__version__ = get_versions()["version"]
del get_versions